Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add abort reason support #1686

Merged
merged 5 commits into from Oct 17, 2022

Conversation

KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented Oct 5, 2022

Implements whatwg/fetch@c9039b9

Allows aborting with custom errors. For example, when using AbortSignal.timeout, a TimeoutError DOMException will now be thrown instead of an AbortError.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Base: 94.19% // Head: 94.19% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2d580d3) compared to base (ab99638).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1686   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files          53       53           
  Lines        4890     4893    +3     
=======================================
+ Hits         4606     4609    +3     
  Misses        284      284           
Impacted Files Coverage Δ
lib/fetch/index.js 83.73% <91.66%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KhafraDev KhafraDev requested a review from ronag October 11, 2022 17:20
@mcollina mcollina merged commit cc58f6e into nodejs:main Oct 17, 2022
@KhafraDev KhafraDev deleted the add-abort-reason-support branch October 17, 2022 14:21
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* feat: add abort reason support

* fix: set default error for node v16

* fix: jest test on v16.8

* add tests

* lint
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* feat: add abort reason support

* fix: set default error for node v16

* fix: jest test on v16.8

* add tests

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants