Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add response WPTs #1684

Merged
merged 1 commit into from Oct 5, 2022
Merged

feat: add response WPTs #1684

merged 1 commit into from Oct 5, 2022

Conversation

KhafraDev
Copy link
Member

Add most response wpts. Didn't add 1 file because just about every test failed (seemed to be an issue with node's web streams or structuredClone, didn't look into it though).

All of the added expected fails have to do with the formData body mixin method, other than 1 test which required FileReader.

398 tests -> 587 tests with only 4 extra failures and only 1 small fix needed🚀

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Base: 94.25% // Head: 94.21% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (63ae090) compared to base (733b3a0).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1684      +/-   ##
==========================================
- Coverage   94.25%   94.21%   -0.04%     
==========================================
  Files          53       53              
  Lines        4887     4890       +3     
==========================================
+ Hits         4606     4607       +1     
- Misses        281      283       +2     
Impacted Files Coverage Δ
lib/fetch/body.js 96.33% <50.00%> (-0.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronag ronag merged commit 0983859 into nodejs:main Oct 5, 2022
@KhafraDev KhafraDev deleted the add-wpts branch October 5, 2022 14:34
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants