Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wpt): broken test #1683

Merged
merged 3 commits into from Oct 5, 2022
Merged

Conversation

KhafraDev
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Base: 94.25% // Head: 94.18% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (a952f7b) compared to base (733b3a0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
- Coverage   94.25%   94.18%   -0.07%     
==========================================
  Files          53       53              
  Lines        4887     4887              
==========================================
- Hits         4606     4603       -3     
- Misses        281      284       +3     
Impacted Files Coverage Δ
lib/fetch/request.js 85.08% <ø> (ø)
lib/core/connect.js 98.27% <0.00%> (-1.73%) ⬇️
lib/fetch/file.js 91.76% <0.00%> (-1.18%) ⬇️
lib/fetch/index.js 83.64% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ab99638 into nodejs:main Oct 5, 2022
@KhafraDev KhafraDev deleted the readablestream-duplex branch October 5, 2022 14:34
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* fix(wpt): broken test

* fix: failing node-fetch tests

* fix: more failing tests
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* fix(wpt): broken test

* fix: failing node-fetch tests

* fix: more failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants