Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock: use http.STATUS_CODES #1641

Merged
merged 1 commit into from Sep 9, 2022
Merged

Conversation

KhafraDev
Copy link
Member

You learn something new exists everyday.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #1641 (69ffd6f) into main (33934f8) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
- Coverage   94.67%   94.56%   -0.12%     
==========================================
  Files          53       53              
  Lines        4866     4803      -63     
==========================================
- Hits         4607     4542      -65     
- Misses        259      261       +2     
Impacted Files Coverage Δ
lib/mock/mock-utils.js 100.00% <100.00%> (ø)
lib/core/connect.js 98.27% <0.00%> (-1.73%) ⬇️
lib/fetch/file.js 91.76% <0.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0862fba into nodejs:main Sep 9, 2022
@KhafraDev KhafraDev deleted the http-status_codes branch September 9, 2022 14:15
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants