fix(fetch): hangs on a stream response with manual redirect #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
approved these changes
Aug 30, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 What's in there?
We found out that
fetch()hangs when consuming the stream body of a redirect, when{ redirect: 'manual' }is set.Full discussion: #1618
🧪 How to test?
It's covered with unit test:
npm run test:fetchWithout the fix, you'll see a new test failing like this:
FAIL test/fetch/client-fetch.js ✖ terminated fetchParams.controller.controller.error( new TypeError('terminated', { ----------^ cause: isErrorLike(reason) ? reason : undefined }) test: redirect with stream stack: | Fetch.onAborted (lib/fetch/index.js:1913:11) Fetch.terminate (lib/fetch/index.js:83:10) Object.onError (lib/fetch/index.js:2061:36) Request.onError (lib/core/request.js:265:27) errorRequest (lib/client.js:1722:13) Object.abort (lib/client.js:1335:7) Object.destroy (lib/fetch/index.js:1571:21) httpFetch (lib/fetch/index.js:1066:41) at: line: 1913 column: 11 file: lib/fetch/index.js function: Fetch.onAborted type: TypeError tapCaught: unhandledRejection