Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capture error stack traces #1619

Merged
merged 3 commits into from Aug 27, 2022
Merged

Conversation

sidwebworks
Copy link
Contributor

Resolves: #1599

Checklist:

  • Add a new test case
  • Lint, Build and Test

@sidwebworks
Copy link
Contributor Author

@mcollina Please review 🙂

@ronag ronag requested a review from mcollina August 26, 2022 20:15
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

I think we might need a test for the `index

wdyt @KhafraDev?

test/client-error-stack-trace.js Outdated Show resolved Hide resolved
@sidwebworks sidwebworks requested review from mcollina and removed request for KhafraDev August 26, 2022 20:54
@sidwebworks
Copy link
Contributor Author

sidwebworks commented Aug 26, 2022

Oops, looks like something broke in the tests

@mcollina any clues as to why this fails on node 14? my guess is that I am testing fetch-index.js at the wrong place maybe?

What's the difference between fetch and fetch-index? I used to think undici was isomorphic 🤔

@KhafraDev
Copy link
Member

KhafraDev commented Aug 26, 2022

@sidwebworks move the test file to the test/fetch folder

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #1619 (b99ede4) into main (6a87bfb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage   94.92%   94.93%           
=======================================
  Files          50       50           
  Lines        4792     4798    +6     
=======================================
+ Hits         4549     4555    +6     
  Misses        243      243           
Impacted Files Coverage Δ
index-fetch.js 100.00% <100.00%> (ø)
index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sidwebworks
Copy link
Contributor Author

sidwebworks commented Aug 26, 2022

@KhafraDev Thank you for the help

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 03cfc4b into nodejs:main Aug 27, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The line where fetch is called doesn't show in the stack trace
4 participants