Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prioritise error events over timeouts #1551

Merged
merged 3 commits into from Jul 20, 2022
Merged

fix: prioritise error events over timeouts #1551

merged 3 commits into from Jul 20, 2022

Commits on Jul 17, 2022

  1. fix: prioritise error events over timeouts 

    Error events in the implementation of 'net.connect' are defered to the next tick: https://github.com/nodejs/node/blob/main/lib/net.js#L1144
This will result in the TO callback always being executed before the error events callback in the callback queue.

This fix makes sure that error event callbacks are executed before the TO socket destroy logic.

fixes #1484
    @jodevsa
    jodevsa committed Jul 17, 2022
    Copy the full SHA
    125ba53 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Merge branch 'nodejs:main' into fix_1484

    @jodevsa
    jodevsa committed Jul 19, 2022
    Copy the full SHA
    b89b9d1 View commit details
    Browse the repository at this point in the history

  2. fixes

    @jodevsa
    jodevsa committed Jul 19, 2022
    Copy the full SHA
    1ffe0e6 View commit details
    Browse the repository at this point in the history