Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up exclude in CI #1544

Merged
merged 1 commit into from Jul 14, 2022
Merged

Fix up exclude in CI #1544

merged 1 commit into from Jul 14, 2022

Conversation

dominykas
Copy link
Member

Unfortunately, shared worklfows can't take objects as params - this needs to be a string...

Unfortunately, shared worklfows can't take objects as params - this needs to be a string...
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #1544 (da42b10) into main (93e31a2) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
- Coverage   94.90%   94.88%   -0.03%     
==========================================
  Files          50       50              
  Lines        4633     4633              
==========================================
- Hits         4397     4396       -1     
- Misses        236      237       +1     
Impacted Files Coverage Δ
lib/fetch/file.js 91.66% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b57e8c...da42b10. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 22e2f39 into nodejs:main Jul 14, 2022
@dominykas dominykas deleted the patch-1 branch July 15, 2022 07:24
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
Unfortunately, shared worklfows can't take objects as params - this needs to be a string...
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Unfortunately, shared worklfows can't take objects as params - this needs to be a string...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants