Skip to content

feat(webidl): add error messages #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented Jun 20, 2022

Adds error messages throughout fetch (everything that was missing a message).


My last PR for today. The WebIDL implementation should be done after this, unless there are any bugs.

@codecov-commenter
Copy link

Codecov Report

Merging #1508 (9456dc0) into main (98af06f) will decrease coverage by 0.00%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
- Coverage   94.64%   94.63%   -0.01%     
==========================================
  Files          50       50              
  Lines        4575     4589      +14     
==========================================
+ Hits         4330     4343      +13     
- Misses        245      246       +1     
Impacted Files Coverage Δ
lib/fetch/headers.js 94.40% <92.85%> (-0.56%) ⬇️
lib/fetch/webidl.js 98.28% <95.83%> (+0.09%) ⬆️
lib/fetch/body.js 98.52% <100.00%> (+0.01%) ⬆️
lib/fetch/formdata.js 96.07% <100.00%> (ø)
lib/fetch/request.js 82.23% <100.00%> (ø)
lib/fetch/response.js 94.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98af06f...9456dc0. Read the comment docs.

@ronag
Copy link
Member

ronag commented Jun 21, 2022

The WebIDL implementation should be done after this, unless there are any bugs.

What about body.js?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 7d9fd51 into nodejs:main Jun 21, 2022
@KhafraDev KhafraDev deleted the webidl-errors branch June 21, 2022 14:43
@KhafraDev
Copy link
Member Author

Nothing should need to be done in body.js; no methods take parameters and brand checks were recently added.

KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022

Unverified

This user has not yet uploaded their public signing key.
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants