Skip to content

feat(Response): webidl checks #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2022
Merged

feat(Response): webidl checks #1506

merged 2 commits into from
Jun 20, 2022

Conversation

KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented Jun 20, 2022

  • Adds idl checks to Response
  • Adds unsigned short idl conversion (required by Response).
  • Fixes 2 bugs in webidl.dictionaryConverter (tests added for these)

All tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #1506 (acf0d16) into main (5f681a8) will decrease coverage by 0.01%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   94.78%   94.77%   -0.02%     
==========================================
  Files          50       50              
  Lines        4526     4553      +27     
==========================================
+ Hits         4290     4315      +25     
- Misses        236      238       +2     
Impacted Files Coverage Δ
lib/fetch/response.js 93.02% <94.11%> (-0.32%) ⬇️
lib/fetch/webidl.js 98.05% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f681a8...acf0d16. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 8b5f8ba into nodejs:main Jun 20, 2022
@KhafraDev KhafraDev deleted the response-webidl branch June 20, 2022 19:09
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022

Unverified

This user has not yet uploaded their public signing key.
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants