New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fetch): missing body-mixin brand checks #1498
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
- Coverage 94.74% 94.64% -0.10%
==========================================
Files 49 49
Lines 4297 4312 +15
==========================================
+ Hits 4071 4081 +10
- Misses 226 231 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify in the PR description what this does? It's a bit unclear:
Done, sorry 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This adds brand checks to body mixin methods & properties. These are webidl checks done throughout the spec. This disallows the following:
These checks are already done everywhere else.
Refs: #1436 #1430