Skip to content

fix(types): import URL #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022
Merged

fix(types): import URL #1494

merged 1 commit into from
Jun 14, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jun 14, 2022

For various reasons, we are stuck on a slightly older @types/node which doesn't have the global URL declaration. Importing it explicitly fixes that, without any negative side-effects

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 8e9d902 into nodejs:main Jun 14, 2022
@SimenB SimenB deleted the patch-1 branch June 14, 2022 10:12
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022

Verified

This commit was signed with the committer’s verified signature.
metcoder95 Carlos Fuentes
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants