Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove headers filtering #1469

Merged
merged 5 commits into from May 30, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions lib/fetch/request.js
Expand Up @@ -383,10 +383,10 @@ class Request {
// 30. Set this’s headers to a new Headers object with this’s relevant
// Realm, whose header list is request’s header list and guard is
// "request".
this[kHeaders] = new Headers()
this[kHeaders] = new Headers(request.headersList)
KhafraDev marked this conversation as resolved.
Show resolved Hide resolved
this[kHeaders][kGuard] = 'request'
this[kHeaders][kHeadersList] = request.headersList
this[kHeaders][kRealm] = this[kRealm]
this[kState].headersList = this[kHeaders][kHeadersList]

// 31. If this’s request’s mode is "no-cors", then:
if (mode === 'no-cors') {
Expand All @@ -406,26 +406,26 @@ class Request {
if (Object.keys(init).length !== 0) {
// 1. Let headers be a copy of this’s headers and its associated header
// list.
let headers = new Headers(this.headers)
let headers = new Headers(this[kHeaders])

// 2. If init["headers"] exists, then set headers to init["headers"].
if (init.headers !== undefined) {
headers = init.headers
}

// 3. Empty this’s headers’s header list.
this[kState].headersList = new HeadersList()
this[kHeaders][kHeadersList] = this[kState].headersList
this[kHeaders] = new Headers()
this[kState].headersList = this[kHeaders][kHeadersList]
KhafraDev marked this conversation as resolved.
Show resolved Hide resolved

// 4. If headers is a Headers object, then for each header in its header
// list, append header’s name/header’s value to this’s headers.
if (headers.constructor.name === 'Headers') {
for (const [key, val] of headers[kHeadersList] || headers) {
this[kState].headersList.append(key, val)
for (const [key, val] of headers) {
KhafraDev marked this conversation as resolved.
Show resolved Hide resolved
this[kHeaders].append(key, val)
}
} else {
// 5. Otherwise, fill this’s headers with headers.
fillHeaders(this[kState].headersList, headers)
fillHeaders(this[kHeaders], headers)
}
}

Expand Down Expand Up @@ -461,7 +461,7 @@ class Request {
// not contain `Content-Type`, then append `Content-Type`/Content-Type to
// this’s headers.
if (contentType && !this[kHeaders].has('content-type')) {
this[kState].headersList.append('content-type', contentType)
this[kHeaders].append('content-type', contentType)
}
}

Expand Down