Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: invalid callback for client connect/upgrade #798

Merged
merged 3 commits into from May 10, 2021
Merged

test: invalid callback for client connect/upgrade #798

merged 3 commits into from May 10, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 9, 2021

Adds unit tests for:

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #798 (3ccf752) into main (e0f0bad) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   99.75%   99.85%   +0.09%     
==========================================
  Files          26       26              
  Lines        2009     2009              
==========================================
+ Hits         2004     2006       +2     
+ Misses          5        3       -2     
Impacted Files Coverage Δ
lib/api/api-upgrade.js 100.00% <0.00%> (+2.17%) ⬆️
lib/api/api-connect.js 100.00% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f0bad...3ccf752. Read the comment docs.

@trivikr trivikr changed the title test: client.upgrade invalid callback test: invalid callback for client connect/upgrade May 9, 2021
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4818569 into nodejs:main May 10, 2021
@trivikr trivikr deleted the test-client-upgrade branch May 10, 2021 01:58
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants