test: invalid callback for client connect/upgrade (#798)

nodejs · May 10, 2021 · 4818569 · 4818569
1 parent 091a4a9
commit 4818569
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/test/client-connect.js b/test/client-connect.js
@@ -114,18 +114,29 @@ test('connect error', (t) => {
 })
 
 test('connect invalid opts', (t) => {
-  t.plan(2)
+  t.plan(6)
 
   const client = new Client('http://localhost:5432')
 
   client.connect(null, err => {
     t.ok(err instanceof errors.InvalidArgumentError)
+    t.equal(err.message, 'invalid opts')
   })
 
   try {
     client.connect(null, null)
+    t.fail()
+  } catch (err) {
+    t.ok(err instanceof errors.InvalidArgumentError)
+    t.equal(err.message, 'invalid opts')
+  }
+
+  try {
+    client.connect({ path: '/' }, null)
+    t.fail()
   } catch (err) {
     t.ok(err instanceof errors.InvalidArgumentError)
+    t.equal(err.message, 'invalid callback')
   }
 })
 

diff --git a/test/client-upgrade.js b/test/client-upgrade.js
@@ -146,18 +146,29 @@ test('upgrade error', (t) => {
 })
 
 test('upgrade invalid opts', (t) => {
-  t.plan(2)
+  t.plan(6)
 
   const client = new Client('http://localhost:5432')
 
   client.upgrade(null, err => {
     t.ok(err instanceof errors.InvalidArgumentError)
+    t.equal(err.message, 'invalid opts')
   })
 
   try {
     client.upgrade(null, null)
+    t.fail()
+  } catch (err) {
+    t.ok(err instanceof errors.InvalidArgumentError)
+    t.equal(err.message, 'invalid opts')
+  }
+
+  try {
+    client.upgrade({ path: '/' }, null)
+    t.fail()
   } catch (err) {
     t.ok(err instanceof errors.InvalidArgumentError)
+    t.equal(err.message, 'invalid callback')
   }
 })