Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept close as message complete #1726

Merged
merged 1 commit into from Oct 23, 2022
Merged

fix: accept close as message complete #1726

merged 1 commit into from Oct 23, 2022

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 23, 2022

Fixes: #1670

@ronag ronag requested a review from mcollina October 23, 2022 14:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Base: 93.98% // Head: 94.91% // Increases project coverage by +0.92% 🎉

Coverage data is based on head (916ae52) compared to base (d7c74f7).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
+ Coverage   93.98%   94.91%   +0.92%     
==========================================
  Files          53       39      -14     
  Lines        4907     2813    -2094     
==========================================
- Hits         4612     2670    -1942     
+ Misses        295      143     -152     
Impacted Files Coverage Δ
lib/client.js 96.84% <50.00%> (-0.80%) ⬇️
index.js 80.00% <0.00%> (-20.00%) ⬇️
lib/handler/RedirectHandler.js 83.54% <0.00%> (-11.40%) ⬇️
lib/core/util.js 87.58% <0.00%> (-10.35%) ⬇️
lib/api/readable.js 82.75% <0.00%> (-8.63%) ⬇️
lib/core/request.js 92.54% <0.00%> (-7.46%) ⬇️
lib/proxy-agent.js 87.67% <0.00%> (-5.48%) ⬇️
lib/mock/mock-utils.js 95.13% <0.00%> (-4.87%) ⬇️
lib/core/connect.js 98.27% <0.00%> (-1.73%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 7c6040b into main Oct 23, 2022
@mcollina mcollina deleted the fix-1670 branch October 27, 2022 10:07
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UND_ERR_SOCKET thrown when fetching certain endpoints of the GitHub API
3 participants