fix: accept close as message complete (#1726)

nodejs · Oct 23, 2022 · 7c6040b · 7c6040b
1 parent f57fe82
commit 7c6040b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 17 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -549,19 +549,6 @@ class Parser {
     }
   }
 
-  finish () {
-    try {
-      try {
-        currentParser = this
-      } finally {
-        currentParser = null
-      }
-    } catch (err) {
-      /* istanbul ignore next: difficult to make a test case for */
-      util.destroy(this.socket, err)
-    }
-  }
-
   destroy () {
     assert(this.ptr != null)
     assert(currentParser == null)
@@ -924,7 +911,7 @@ function onSocketError (err) {
   // to the user.
   if (err.code === 'ECONNRESET' && parser.statusCode && !parser.shouldKeepAlive) {
     // We treat all incoming data so for as a valid response.
-    parser.finish()
+    parser.onMessageComplete()
     return
   }
 
@@ -958,7 +945,7 @@ function onSocketEnd () {
 
   if (parser.statusCode && !parser.shouldKeepAlive) {
     // We treat all incoming data so far as a valid response.
-    parser.finish()
+    parser.onMessageComplete()
     return
   }
 
@@ -968,6 +955,11 @@ function onSocketEnd () {
 function onSocketClose () {
   const { [kClient]: client } = this
 
+  if (!this[kError] && this[kParser].statusCode && !this[kParser].shouldKeepAlive) {
+    // We treat all incoming data so far as a valid response.
+    this[kParser].onMessageComplete()
+  }
+
   this[kParser].destroy()
   this[kParser] = null
 

diff --git a/test/content-length.js b/test/content-length.js
@@ -281,7 +281,7 @@ test('response invalid content length with close', (t) => {
     t.teardown(client.destroy.bind(client))
 
     client.on('disconnect', (origin, client, err) => {
-      t.equal(err.code, 'UND_ERR_SOCKET')
+      t.equal(err.code, 'UND_ERR_RES_CONTENT_LENGTH_MISMATCH')
     })
 
     client.request({
@@ -294,7 +294,7 @@ test('response invalid content length with close', (t) => {
           t.fail()
         })
         .on('error', (err) => {
-          t.equal(err.code, 'UND_ERR_SOCKET')
+          t.equal(err.code, 'UND_ERR_RES_CONTENT_LENGTH_MISMATCH')
         })
         .resume()
     })

diff --git a/test/issue-1670.js b/test/issue-1670.js
@@ -0,0 +1,12 @@
+'use strict'
+
+const { test } = require('tap')
+const { request } = require('..')
+
+test('https://github.com/mcollina/undici/issues/810', async (t) => {
+  const { body } = await request('https://api.github.com/user/emails')
+
+  await body.text()
+
+  t.end()
+})