Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(fetch): set content-length header for FormData body (#1785)
* fix(fetch): set content-length header for FormData body * fix: skip test on v16 * fix: remove test * test: add test back
- Loading branch information
Showing
2 changed files
with
60 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
'use strict' | ||
|
||
const { test } = require('tap') | ||
const { createServer } = require('http') | ||
const { once } = require('events') | ||
const { Blob } = require('buffer') | ||
const { fetch, FormData } = require('../..') | ||
|
||
// https://github.com/nodejs/undici/issues/1783 | ||
test('Content-Length is set when using a FormData body with fetch', async (t) => { | ||
const server = createServer((req, res) => { | ||
// TODO: check the length's value once the boundary has a fixed length | ||
t.ok('content-length' in req.headers) // request has content-length header | ||
t.ok(!Number.isNaN(Number(req.headers['content-length']))) | ||
res.end() | ||
}).listen(0) | ||
|
||
await once(server, 'listening') | ||
t.teardown(server.close.bind(server)) | ||
|
||
const fd = new FormData() | ||
fd.set('file', new Blob(['hello world 👋'], { type: 'text/plain' }), 'readme.md') | ||
fd.set('string', 'some string value') | ||
|
||
await fetch(`http://localhost:${server.address().port}`, { | ||
method: 'POST', | ||
body: fd | ||
}) | ||
}) |