fix: use weak listener for fetch abort

Fixes: #939
nodejs · Nov 18, 2021 · 94ba37e · 94ba37e
1 parent 3b1b03c
commit 94ba37e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/fetch/request.js b/lib/fetch/request.js
@@ -328,13 +328,12 @@ class Request {
       if (signal.aborted) {
         ac.abort()
       } else {
-        // TODO: Remove this listener on failure/success.
         signal.addEventListener(
           'abort',
           function () {
             ac.abort()
           },
-          { once: true }
+          { once: true, weak: true }
         )
       }
     }
@@ -700,7 +699,7 @@ class Request {
         function () {
           ac.abort()
         },
-        { once: true }
+        { once: true, weak: true }
       )
     }
     clonedRequestObject[kSignal] = ac.signal