minor hook error handling

nodejs · Mar 31, 2024 · 06a6d35 · 06a6d35
1 parent 7fb8232
commit 06a6d35
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/lib/core/request.js b/lib/core/request.js
@@ -223,7 +223,11 @@ class Request {
       abort(this.error)
     } else {
       this.abort = abort
-      return this[kHandler].onConnect(abort)
+      try {
+        return this[kHandler].onConnect(abort)
+      } catch (err) {
+        abort(err)
+      }
     }
   }
 
@@ -262,7 +266,12 @@ class Request {
     assert(!this.aborted)
     assert(!this.completed)
 
-    return this[kHandler].onUpgrade(statusCode, headers, socket)
+    try {
+      return this[kHandler].onUpgrade(statusCode, headers, socket)
+    } catch (err) {
+      // TODO (fix): This might be a bad idea?
+      this.onError(err)
+    }
   }
 
   onComplete (trailers) {
@@ -295,6 +304,7 @@ class Request {
     }
     this.aborted = true
 
+    // TODO (fix): What if onError throws?
     return this[kHandler].onError(error)
   }