Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add GitHub Actions CI #418

Merged
merged 6 commits into from Sep 23, 2020
Merged

tests: add GitHub Actions CI #418

merged 6 commits into from Sep 23, 2020

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Sep 26, 2019

PR to attempt adding GitHub Actions CI as a parallel to/eventual (?) replacement for TravisCI.

Varied a bit from the setups I've done so far, so I don't fully expect this to work on the first run. That said, I'll be working to get it passing.

Few things to note:

  • There's not currently (AFAIK) a Sauce Labs Action that parallels what TravisCI currently does. I reached out on Twitter to ask if something existed or was planned, and @christian-bromann started working on an Action. Ideally we'd be able to use that once it's done ❤️
  • The configuration to parallel CMD=test and CMD=test-browser is relatively straightforward and documented here, but omitted from this PR since the PR does not currently include Sauce Labs.
  • I opted to run on all platforms since that's a personal preference of mine, but if there are platforms you'd prefer to be removed I'm happy to do so.

@bnb
Copy link
Contributor Author

bnb commented Sep 26, 2019

Hmm, theoretically the Checks should have run, though I could (?) be wrong about that. Double checking in a dummy repo.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@vweevers
Copy link
Contributor

What's the motivation for replacing Travis?

Co-Authored-By: Michaël Zasso <targos@protonmail.com>
@bnb
Copy link
Contributor Author

bnb commented Sep 26, 2019

Per my understanding from a Build WG member when I asked about GitHub CI, it was agreed to attempt using GitHub CI in a few repos in the org that already use TravisCI. If it works as a reasonable replacement, it could eventually become that but for now perhaps not the goal we'd be going for.

@bnb
Copy link
Contributor Author

bnb commented Sep 26, 2019

Looking into how I can trigger this correctly. Will update as appropriate ❤️

@bnb
Copy link
Contributor Author

bnb commented Sep 26, 2019

Ah, it looks like they're running on my repo, it's just not being surfaced here! Excellent.

There's a failure with tap not being available, I'm realizing that's likely caused because I removed npm install. Will address and progress can be followed there ❤️

@bnb
Copy link
Contributor Author

bnb commented Sep 26, 2019

Passed!

It's worth noting that this GitHub Actions CI build was triggered 6 minutes ago (from time of comment) and already completed on all operating systems on all versions, while TravisCI is waiting to be queued 😬

Edit: Link to passed run

@bnb
Copy link
Contributor Author

bnb commented Sep 26, 2019

Also, I noticed that the Travis run only tests Linux. I'd be happy to remove macos-latst and windows-latest if that'd be the preferred path of the maintainers.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Are tests passing already on Windows?

.github/workflows/ci.yml Show resolved Hide resolved
@bnb
Copy link
Contributor Author

bnb commented Oct 25, 2019

Are tests passing already on Windows?

Seems like it 👍

Copy link
Contributor

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Regarding Sauce Labs, I can open a PR to create a separate workflow with an upgraded airtap (which now supports GH Actions).

@christian-bromann
Copy link

  • There's not currently (AFAIK) a Sauce Labs Action that parallels what TravisCI currently does. I reached out on Twitter to ask if something existed or was planned, and @christian-bromann started working on an Action. Ideally we'd be able to use that once it's done

The GitHub action is done: https://github.com/saucelabs/sauce-connect-action

@vweevers
Copy link
Contributor

@christian-bromann Nice, thanks! Though we no longer need it here.

@mcollina mcollina merged commit 69aa464 into nodejs:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants