Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Hindi language #6570 #6571

Closed
wants to merge 2 commits into from

Conversation

G-nizam-A
Copy link

Description

This PR enables Hindi language support in the application by implementing functionality to dynamically load Hindi translations when the user selects Hindi as their preferred language. It includes updating the codebase to handle language selection and loading the corresponding translation files for Hindi. Additionally, it ensures that the application's user interface elements are appropriately localized in Hindi.

Validation

image

Related Issues

Fixes #6570 Related to #6508

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@G-nizam-A G-nizam-A requested a review from a team as a code owner March 27, 2024 13:07
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:09pm

"langDir": "ltr",
"dateFormat": "DD/MM/YYYY",
"hrefLang": "hi",
"enabled": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"enabled": true,
"enabled": false,

@@ -0,0 +1,291 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLEASE, read translation.md

Comment on lines +11 to +13
} else if (locale === 'hi') {
// This enables Hindi locale
return import('./i18n/locales/hi.json').then(f => f.default);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else if (locale === 'hi') {
// This enables Hindi locale
return import('./i18n/locales/hi.json').then(f => f.default);
} else if (locale === 'hi') {
// This enables Hindi locale
return import('./i18n/locales/hi.json').then(f => f.default);

remove that

@AugustinMauroy AugustinMauroy added the i18n Issues/PRs related to the Website Internationalisation label Mar 27, 2024
@AugustinMauroy AugustinMauroy mentioned this pull request Mar 27, 2024
5 tasks
@G-nizam-A G-nizam-A closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Hindi Language Support
2 participants