New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: update ongoing promise in async iterator return()
method
#52657
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
MattiasBuelens:streams-async-iterator-return-update-ongoing
Apr 28, 2024
Merged
stream: update ongoing promise in async iterator return()
method
#52657
nodejs-github-bot
merged 2 commits into
nodejs:main
from
MattiasBuelens:streams-async-iterator-return-update-ongoing
Apr 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
MattiasBuelens
changed the title
streams: update ongoing promise in async iterator
stream: update ongoing promise in async iterator Apr 23, 2024
return()
methodreturn()
method
MattiasBuelens
force-pushed
the
streams-async-iterator-return-update-ongoing
branch
from
April 23, 2024 21:33
e3b75f7
to
668a13f
Compare
mcollina
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
debadree25
approved these changes
Apr 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
debadree25
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 24, 2024
benjamingr
approved these changes
Apr 24, 2024
jasnell
approved these changes
Apr 27, 2024
mcollina
added
commit-queue
Add this label to land a pull request using GitHub Actions.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
and removed
needs-ci
PRs that need a full CI run.
labels
Apr 28, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 28, 2024
Landed in eee9db8 |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52657 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
web streams
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51725