Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: apply workaround for msbuild 16.10.0 only #38930

Closed
wants to merge 2 commits into from

Conversation

richardlau
Copy link
Member

Only apply the msbuild target workaround for msbuild 16.10.0 only as
that is the version containing the regression and the workaround will
still be needed if building with that version even when a newer version
of msbuild is available.

Refs: dotnet/msbuild#6465
Refs: #38872
Refs: #38873

cc @targos @nodejs/platform-windows

Only apply the msbuild target workaround for msbuild 16.10.0 only as
that is the version containing the regression and the workaround will
still be needed if building with that version even when a newer version
of msbuild is available.
@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels Jun 4, 2021
vcbuild.bat Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Jun 4, 2021

Why would we like to keep the workaround when 16.10.1 is released? We do not usually support every possible version of required tools.

@richardlau
Copy link
Member Author

🤷 We claim to support "Visual Studio >= 2019 with the Windows 10 SDK on a 64-bit host" (https://github.com/nodejs/node/blob/master/BUILDING.md#supported-toolchains) and don't specify it needs to be the latest available VS 2019. For example, the Windows hosts on our Jenkins CI is running msbuild 16.9.0 and hasn't been updated to 16.10.0 (they also run in a configuration where target is already Build and not node so would not run into the original issue anyway).

This change would keep the previous behaviour with older msbuild (i.e. anyone who hasn't yet updated to 16.10.0).

I'm not too fussed over this so if the consensus is to not bother we can just close.

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@richardlau richardlau closed this Jun 15, 2021
@richardlau richardlau deleted the msbuild branch June 15, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants