Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.23.3 proposal #37241

Merged
merged 5 commits into from
Feb 9, 2021
Merged

v10.23.3 proposal #37241

merged 5 commits into from
Feb 9, 2021

Commits on Feb 8, 2021

  1. crypto: fix crash when calling digest after piping

    When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in
    hash._flush, bypassing safeguards in the JavaScript layer. Calling
    hash.digest causes EVP_DigestFinal_ex to be called again, resulting
    in a segmentation fault in the SHA3 implementation of OpenSSL.
    
    A relatively easy solution is to cache the result of calling
    EVP_DigestFinal_ex until the Hash object is garbage collected.
    
    PR-URL: #28251
    Fixes: #28245
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    
    Backport-PR-URL: #37009
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    tniessen authored and richardlau committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    953a850 View commit details
    Browse the repository at this point in the history
  2. test: add test that verifies crypto stream pipeline

    This test fails prior to 990feaf being cherry-picked
    due to stream.pipeline with a crypto.Hash not working properly.
    
    That bug also seems to have affected md5.
    
    PR-URL: #37009
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    evanlucas authored and richardlau committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1c6fbd6 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Revert "deps: upgrade npm to 6.14.11"

    This reverts commit cc6b695.
    
    PR-URL: #37278
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Ruy Adorno <ruyadorno@github.com>
    richardlau committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    7b7fb43 View commit details
    Browse the repository at this point in the history
  2. deps: upgrade npm to 6.14.11

    PR-URL: #37173
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    
    Backport-PR-URL: #37278
    
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Ruy Adorno <ruyadorno@github.com>
    ruyadorno authored and richardlau committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    fe2c980 View commit details
    Browse the repository at this point in the history
  3. 2021-02-09, Version 10.23.3 'Dubnium' (LTS)

    Notable changes:
    
    The update to npm 6.14.11 has been relanded so that npm correctly reports its version.
    
    PR-URL: #37241
    richardlau committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    ef1c506 View commit details
    Browse the repository at this point in the history