[v10.x] src: allows escaping NODE_OPTIONS with backslashes #35342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The characters specified within NODE_OPTIONS can now be escaped, which is handy especially in conjunction with `--require` (where the file path might happen to contain spaces that shouldn't cause the option to be split into two). Fixes: nodejs#12971 PR-URL: nodejs#24065 Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot
added
c++
|
/cc @atian25 |
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
|
Ping @nodejs/LTS |
4 tasks
richardlau
approved these changes
Oct 7, 2020
richardlau
pushed a commit
that referenced
this pull request
Oct 7, 2020
The characters specified within NODE_OPTIONS can now be escaped, which is handy especially in conjunction with `--require` (where the file path might happen to contain spaces that shouldn't cause the option to be split into two). Fixes: #12971 PR-URL: #24065 Backport-PR-URL: #35342 Reviewed-By: Anna Henningsen <anna@addaleax.net> Refs: microsoft/vscode-js-debug#769
|
Landed in 2eb6273. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The characters specified within NODE_OPTIONS can now be escaped, which
is handy especially in conjunction with
--require(where the file pathmight happen to contain spaces that shouldn't cause the option to be
split into two).
This PR adds v10.x-compatible commits in addition to backport of #24065.
Fixes: #12971
Refs: microsoft/vscode-js-debug#769
PR-URL: #24065
Reviewed-By: @addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes