Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.22.0 proposal #34170

Merged
merged 22 commits into from
Jul 21, 2020
Merged

v10.22.0 proposal #34170

merged 22 commits into from
Jul 21, 2020

Commits on Jun 2, 2020

  1. build: allow clang 10+ in configure.py

    Detected on NetBSD/amd64.
    
    Fixes: #29536
    
    PR-URL: #29541
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    krytarowski authored and BethGriggs committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    24b927a View commit details
    Browse the repository at this point in the history
  2. build: move doc versions JSON file out of out/doc

    Move the generated previous doc versions JSON file out of `out/doc` to
    prevent it being included in the distributed packages.
    
    Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    
    PR-URL: #32728
    Fixes: nodejs/build#2276
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    richardlau authored and BethGriggs committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    145dcc2 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. test: flaky test-stdout-close-catch on freebsd

    Refs: #28803
    
    PR-URL: #32849
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    sam-github authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    5436569 View commit details
    Browse the repository at this point in the history
  2. build: log detected compilers in --verbose mode

    Log the versions of the detected compilers when the configure script
    is run with `--verbose` to help verify which compiler is being used if
    multiple toolchains are installed on the system.
    
    Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    
    PR-URL: #32715
    Backport-PR-URL: #32820
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    9915774 View commit details
    Browse the repository at this point in the history
  3. deps: fix V8 compiler error with clang++-11

    Fixes: #33040
    
      error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to
        'bool' in initializer list [-Wc++11-narrowing]
      ParameterList result{{}, {}, context->VARARGS(), {}};
    
    Occurs twice:
      ../../deps/v8/src/torque/ast-generator.cc:123:32:
      ../../deps/v8/src/torque/ast-generator.cc:144:32:
    
    PR-URL: #33094
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    sam-github authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    89a306b View commit details
    Browse the repository at this point in the history
  4. deps: V8: backport cd21f71f9cb5

    Original commit message:
    
        [parser] Validate destructuring assignment pattern in correct classifier
    
        Previously we'd first accumulate errors to the parent and validate the
        destructuring pattern in the parent. In the case of ParseArguments this
        will invalidly propagate binding pattern errors from one argument to the
        next. The reason why ParseArguments keeps track of binding pattern errors
        is because it could also be used to parse async arrow function parameters.
        If we see async(a,b) we don't yet know whether this is the head of an
        async arrow function, or a call to async with arguments a and b.
    
        Bug: v8:8241
        Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
        Reviewed-on: https://chromium-review.googlesource.com/c/1296229
        Commit-Queue: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#56887}
    
    Refs: v8/v8@cd21f71
    Fixes: #23142
    
    PR-URL: #33862
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    targos authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    3acc89f View commit details
    Browse the repository at this point in the history
  5. inspector: more conservative minimum stack size

    PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
    receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
    which is the musl architecture with the biggest MINSIGSTKSZ so let's
    use that as a lower bound and let's quadruple it just in case.
    
    Backport-PR-URL: #33720
    PR-URL: #27855
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bnoordhuis authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    aaf2f82 View commit details
    Browse the repository at this point in the history
  6. deps: upgrade openssl sources to 1.1.1f

    This updates all sources in deps/openssl/openssl by:
        $ cd deps/openssl/
        $ rm -rf openssl
        $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz
        $ mv openssl-1.1.0h openssl
        $ git add --all openssl
        $ git commit openssl
    
    Backport-PR-URL: #32982
    PR-URL: #32583
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    hassaanp authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    ef9413b View commit details
    Browse the repository at this point in the history
  7. deps: upgrade openssl sources to 1.1.1g

    This updates all sources in deps/openssl/openssl by:
        $ cd deps/openssl/
        $ rm -rf openssl
        $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz
        $ mv openssl-1.1.1g openssl
        $ git add --all openssl
        $ git commit openssl
    
    PR-URL: #32982
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    hassaanp authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    94702c1 View commit details
    Browse the repository at this point in the history
  8. deps: update archs files for OpenSSL-1.1.1g

    After an OpenSSL source update, all the config files need to be
    regenerated and committed by:
       $ cd deps/openssl/config
       $ make
       $ git add deps/openssl/config/archs
       $ git add deps/openssl/openssl/include/crypto/bn_conf.h
       $ git add deps/openssl/openssl/include/crypto/dso_conf.h
       $ git add deps/openssl/openssl/include/openssl/opensslconf.h
       $ git commit
    
    PR-URL: #32982
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    hassaanp authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    745b329 View commit details
    Browse the repository at this point in the history
  9. tls: allow empty subject even with altNames defined

    Behavior described in #11771
    is still true even though the issue is closed.
    
    This PR is to allow DNS and URI names, even when there is not a subject.
    
    Refs: #11771
    
    PR-URL: #22906
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jasonmacgowan authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    74b00cc View commit details
    Browse the repository at this point in the history
  10. doc: document fs.watchFile() bigint option

    This commit documents the bigint option to fs.watchFile(), which
    has been supported since v10.5.0.
    
    PR-URL: #32128
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    cjihrig authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    193d1d0 View commit details
    Browse the repository at this point in the history
  11. Revert "test: mark empty udp tests flaky on OS X"

    This reverts commit 24a4f76.
    
    PR-URL: #32489
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    lpinca authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    3dbd8cd View commit details
    Browse the repository at this point in the history
  12. n-api: add napi_detach_arraybuffer

    As ArrayBuffer#detach is an ecma spec operation
    ([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
    it might be good to have it in N-API.
    
    Fixes: #29674
    PR-URL: #29768
    Backport-PR-URL: #33061
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    legendecas authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    961598b View commit details
    Browse the repository at this point in the history
  13. n-api: implement napi_is_detached_arraybuffer

    This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
    specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer
    
    Closes: #29955
    
    PR-URL: #30613
    Backport-PR-URL: #33061
    Fixes: #29955
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    lundibundi authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    b744ffd View commit details
    Browse the repository at this point in the history
  14. doc,n-api: mark napi_detach_arraybuffer as experimental

    As its actual release stage.
    
    PR-URL: #30703
    Backport-PR-URL: #33061
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    legendecas authored and richardlau committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    5dab101 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. http: disable headersTimeout check when set to zero

    PR-URL: #33307
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ShogunPanda authored and richardlau committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    069b6e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. deps: upgrade npm to 6.14.5

    PR-URL: #33239
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ruyadorno authored and richardlau committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    84fca3c View commit details
    Browse the repository at this point in the history
  2. deps: upgrade npm to 6.14.6

    PR-URL: #34246
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    claudiahdz authored and richardlau committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    97b5952 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. test: remove timers-blocking-callback

    If the bug this test is intented to catch is reintroduced, or if
    5aac4c4 is effectively reverted, many
    (50+) tests time out, rendering this test redundant and unnecessary.
    
    in particular, the following timer tests catch an effective revert of
    5aac4c4:
    
    not ok 21 parallel/test-timers-api-refs
    not ok 22 parallel/test-timers-args
    not ok 23 parallel/test-timers-destroyed
    not ok 25 parallel/test-timers-nested
    not ok 26 parallel/test-timers-interval-throw
    not ok 28 parallel/test-timers-non-integer-delay
    not ok 32 parallel/test-timers-ordering
    not ok 33 parallel/test-timers-refresh
    not ok 34 parallel/test-timers-refresh-in-callback
    not ok 35 parallel/test-timers-reset-process-domain-on-throw
    not ok 40 parallel/test-timers-timeout-to-interval
    not ok 41 parallel/test-timers-uncaught-exception
    not ok 42 parallel/test-timers-timeout-with-non-integer
    not ok 43 parallel/test-timers-unenroll-unref-interval
    not ok 44 parallel/test-timers-unref
    not ok 45 parallel/test-timers-unref-active
    not ok 46 parallel/test-timers-unrefd-interval-still-fires
    not ok 47 parallel/test-timers-unrefed-in-callback
    not ok 48 parallel/test-timers-user-call
    not ok 49 parallel/test-timers-zero-timeout
    
    Refs: #21781
    
    PR-URL: #32870
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Fishrock123 authored and richardlau committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    7a109fe View commit details
    Browse the repository at this point in the history
  2. doc: fix quotes in tls.md

    Added the missing single quotes in minVersion and maxVersion of api/tls
    doc before TLSv1.2.
    
    PR-URL: #33641
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    sparsh-99 authored and richardlau committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    00f04e3 View commit details
    Browse the repository at this point in the history
  3. 2020-07-21, Version 10.22.0 'Dubnium' (LTS)

    Notable changes:
    
    - deps:
      - upgrade npm to 6.14.6 (claudiahdz)
        #34246
      - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
        #32982
    - n-api:
      - add `napi_detach_arraybuffer` (legendecas)
        #29768
    
    PR-URL: #34170
    richardlau committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    c5215d0 View commit details
    Browse the repository at this point in the history