Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.8.0 release proposal #29017

Merged
merged 88 commits into from
Aug 6, 2019
Merged

v12.8.0 release proposal #29017

merged 88 commits into from
Aug 6, 2019

Commits on Aug 2, 2019

  1. deps: float 15d7e79 from openssl

    The upstream commit fixes an incorrect initialization of memory in
    rand_lib.c. This fixes all errors that are reported by valgrind during
    startup.
    
    Origin: openssl/openssl@15d7e7997e219fc
    
    PR-URL: #28796
    Fixes: #28739
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    tniessen authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    19dad19 View commit details
    Browse the repository at this point in the history
  2. src: fix type name in comment

    The comment refers to an exception type that JS land throws on the C++
    code's behalf but apparently I changed the JS name before landing the
    pull request and forgot to update the comment.
    
    Refs: #20816
    
    PR-URL: #28320
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    bnoordhuis authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    e334c1f View commit details
    Browse the repository at this point in the history
  3. lib: support min/max values in validateInteger()

    This commit updates validateInteger() in two ways:
    
    - Number.isInteger() is used instead of Number.isSafeInteger().
      This ensures that all integer values are supported.
    - Minimum and maximum values are supported. They default to
      the min and max safe integer values, but can be customized.
    
    PR-URL: #28810
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cjihrig authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    386d5d7 View commit details
    Browse the repository at this point in the history
  4. module: implement "exports" proposal for CommonJS

    Refs: jkrems/proposal-pkg-exports#36
    Refs: #28568
    
    PR-URL: #28759
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    jkrems authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    2262526 View commit details
    Browse the repository at this point in the history
  5. doc: api/stream.md typo from writeable to writable

    PR-URL: #28822
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    imcotton authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d0b1fb3 View commit details
    Browse the repository at this point in the history
  6. crypto: increase maxmem range from 32 to 53 bits

    Fixes: #28755
    
    PR-URL: #28799
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    e0e7763 View commit details
    Browse the repository at this point in the history
  7. tools: update certdata.txt

    This is the certdata.txt[0] from NSS 3.45, released on 2019-07-05.
    
    This is the version of NSS that will ship in Firefox 69 on
    2019-09-03.
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_45_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #28808
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    sam-github authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    a38fecd View commit details
    Browse the repository at this point in the history
  8. crypto: update root certificates

    Update the list of root certificates in src/node_root_certs.h with
    tools/mk-ca-bundle.pl.
    
    Certificates added: (none)
    
    Certificates removed:
    - Certinomis - Root CA
    
    PR-URL: #28808
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    sam-github authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    86f4c68 View commit details
    Browse the repository at this point in the history
  9. doc: fix type in NSS update instructions

    The perl script must be fully named, correct so that the command can be
    copy-pasted-run from the docs.
    
    PR-URL: #28808
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    sam-github authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    c0a0448 View commit details
    Browse the repository at this point in the history
  10. build: uname -m is amd64 on freebsd, not x86_64

    Fixes: #13150
    
    PR-URL: #28804
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bnoordhuis authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    24b9d29 View commit details
    Browse the repository at this point in the history
  11. src : elevate v8 namespaces

    Leverage `using` semantics for repeated usage of
    v8 artifacts.
    
    PR-URL: #28801
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    HarshithaKP authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    3c30456 View commit details
    Browse the repository at this point in the history
  12. doc: add documentation for response.flushHeaders()

    PR-URL: #28807
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    0667d0c View commit details
    Browse the repository at this point in the history
  13. doc: claim NODE_MODULE_VERSION=76 for Electron 8

    PR-URL: #28809
    Refs: https://github.com/electron/electron/projects/20#card-24099810
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    MarshallOfSound authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    95b87ce View commit details
    Browse the repository at this point in the history
  14. deps: backport b107214 from upstream V8

    Original commit message:
    
        [code-serializer] Handlify in CodeSerializer::Deserialize
    
        This section potentially contains allocations and thus gc, all object
        references should be handlified.
    
        Bug: v8:9333
        Change-Id: I5814e66e8b9b75a8bd952afecae7a3a27b42a642
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647695
        Auto-Submit: Jakob Gruber <jgruber@chromium.org>
        Commit-Queue: Simon Zünd <szuend@chromium.org>
        Reviewed-by: Simon Zünd <szuend@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#62012}
    
    (This required resolution of a few merge conflicts, so it’s essentially
    a manual backport.)
    
    Refs: v8/v8@b107214
    Refs: #28847
    
    PR-URL: #28850
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    addaleax authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    ae56a23 View commit details
    Browse the repository at this point in the history
  15. domain: use strong reference to domain while active

    When an uncaught exception is thrown inside a domain, the domain is
    removed from the stack as of 43a5170.
    This means that it might not be kept alive as an object anymore,
    and may be garbage collected before the `after()` hook can run,
    which tries to exit it as well.
    
    Resolve that by making references to the domain strong while it is
    active.
    
    Fixes: #28275
    
    PR-URL: #28313
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    727ffe4 View commit details
    Browse the repository at this point in the history
  16. doc: describe why new Buffer() is problematic

    Existing docs weren't clear on the actual problem. In addition, the text
    described 8.0.0 as being a future Node.js release, so adjust language
    to reflect that 8.0.0 is in the past (while not losing important
    information about what the pre-8.x behaviour was).
    
    PR-URL: #28825
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    sam-github authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    881e345 View commit details
    Browse the repository at this point in the history
  17. n-api: add APIs for per-instance state management

    Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which
    allow native addons to store their data on and retrieve their data from
    `napi_env`. `napi_set_instance_data()` accepts a finalizer which is
    called when the `node::Environment()` is destroyed.
    
    This entails rendering the `napi_env` local to each add-on.
    
    Fixes: nodejs/abi-stable-node#378
    PR-URL: #28682
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    860c0d8 View commit details
    Browse the repository at this point in the history
  18. doc: fix incorrect name in report docs

    In diagnostic reports, the CPUs are listed in a "cpus" field.
    This commit fixes the docs, which refer to the field as "osCpus"
    
    PR-URL: #28830
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cjihrig authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    454e879 View commit details
    Browse the repository at this point in the history
  19. report: loop over uv_cpu_info() results

    The code currently loops over the results, but only the
    first result is accessed.
    
    PR-URL: #28829
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    e0951c8 View commit details
    Browse the repository at this point in the history
  20. assert: avoid potentially misleading reference to object identity

    Often, the word “identical” when referring to JS objects will
    be read as referring to having the same object identity (which is
    called “reference equality” here), but what the error message is
    trying to say here is that the objects are different but yield the
    same `util.inspect()` output.
    
    Since `util.inspect()` output represents the structure rather than
    the identity of objects, (hopefully) clarify the error message to
    reflect that.
    
    PR-URL: #28824
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    addaleax authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d3426ee View commit details
    Browse the repository at this point in the history
  21. crypto: add outputLength option to crypto.createHash

    This change adds an outputLength option to crypto.createHash which
    allows users to produce variable-length hash values using XOF hash
    functons.
    
    Fixes: #28757
    PR-URL: #28805
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    b7c6ad5 View commit details
    Browse the repository at this point in the history
  22. crypto: fix handling of malicious getters (scrypt)

    It is possible to bypass parameter validation in crypto.scrypt and
    crypto.scryptSync by crafting option objects with malicious getters as
    demonstrated in the regression test. After bypassing validation, any
    value can be passed to the C++ layer, causing an assertion to crash
    the process.
    
    Fixes: #28836
    
    PR-URL: #28838
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    3a62202 View commit details
    Browse the repository at this point in the history
  23. policy: add dependencies map for resources

    Adds a "dependencies" field to resources in policy manifest files.
    In order to ease development and testing while using manifests,
    wildcard values for both "dependencies" and "integrity" have been
    added using the boolean value "true" in the policy manifest.
    
    PR-URL: #28767
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bmeck authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    5d5c89a View commit details
    Browse the repository at this point in the history
  24. doc: add documentation for stream.destroyed

    PR-URL: #28815
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ronag authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    ffc7a00 View commit details
    Browse the repository at this point in the history
  25. n-api: refactor a previous commit

    This is a refactoring of #27628
    following #28505.
    
    This change factors out functions `add_last_status()` and
    `add_returned_status()` so they may be reused in the tests for passing
    information about the last error status and/or a returned `napi_status`
    to JavaScript.
    
    PR-URL: #28848
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Octavian Soldea authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    e6b3bfe View commit details
    Browse the repository at this point in the history
  26. stream: resolve perf regression introduced by V8 7.3

    This commit contains two fixes:
    1. use instanceof instead of Object.getPrototypeOf, as checking an
       object prototype with Object.getPrototypeOf is slower
       than an instanceof check.
    2. avoid parseInt(undefined, 10) to get NaN as it regressed.
    
    PR-URL: #28842
    Fixes: #28586
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mcollina authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    cf071a0 View commit details
    Browse the repository at this point in the history
  27. build,tools: support building with Visual Studio 2019

    Add a `vs2019` option to `vcbuild.bat` to use VS 2019 instead of VS 2017
    
    PR-URL: #28781
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    82f263d View commit details
    Browse the repository at this point in the history
  28. test: specialize OOM check for AIX

    Assumption that if memory can be malloc()ed it can be used is not true
    on AIX. Later access of the allocated pages can trigger SIGKILL if there
    are insufficient VM pages.
    
    Use psdanger() to better estimate available memory.
    
    Fixes: nodejs/build#1849
    
    More info:
    - https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/generalprogramming/sys_mem_alloc.html
    - https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/p_bostechref/psdanger.html
    
    Related to:
    - nodejs/build#1820 (comment)
    - #28469
    - #28516
    
    PR-URL: #28857
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    sam-github authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    f6051f9 View commit details
    Browse the repository at this point in the history
  29. src: move relative uptime init

    PR-URL: #28849
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Micha Hanselmann authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    8db43b1 View commit details
    Browse the repository at this point in the history
  30. http: reset parser.incoming when server response is finished

    This resolves a memory leak for keep-alive connections with a naïve
    approach.
    
    Fixes: #9668
    
    PR-URL: #28646
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    c9c7256 View commit details
    Browse the repository at this point in the history
  31. deps: remove backup files

    PR-URL: #28865
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    AdamMajer authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    24b8f20 View commit details
    Browse the repository at this point in the history
  32. build: ignore backup files

    Prevent backup files from being accidentally automatically added
    to the index.
    
    PR-URL: #28865
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    AdamMajer authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    9e7c662 View commit details
    Browse the repository at this point in the history
  33. crypto: add null check to outputLength logic

    The Hash constructor's outputLength logic checks if the options
    input is an object, but doesn't check for null objects. This
    commit adds that check.
    
    PR-URL: #28864
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cjihrig authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    a7ef102 View commit details
    Browse the repository at this point in the history
  34. test,report: relax CPU match requirements

    Some CPUs have variable speeds, and so exact matches between what
    `os.cpus()` and the report feature yield cannot always be expected:
    
    ```
    >const results = []
    >setInterval(() => results.push(os.cpus().map(({ speed }) => speed)), 1)
    [...]
    >results
    [
      [ 1198, 1150, 1195, 1149 ],
      [ 1198, 1150, 1195, 1149 ],
      [ 1198, 1150, 1195, 1149 ],
      [ 1198, 1150, 1195, 1149 ],
      [ 2401, 2420, 2429, 2413 ],
      [ 2401, 2420, 2429, 2413 ],
      [ 2401, 2420, 2429, 2413 ],
      [ 2401, 2420, 2429, 2413 ],
      [ 2401, 2420, 2429, 2413 ],
      [ 2401, 2420, 2429, 2413 ],
      [ 2401, 2420, 2429, 2413 ],
      [ 2596, 2401, 2699, 2555 ],
    [...]
    ```
    
    Refs: #28829
    
    PR-URL: #28884
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    0b6a84a View commit details
    Browse the repository at this point in the history
  35. test, util: refactor isObject in test-util

    refactor the test for isObject function including falsy values,
    the use of strictEquals and the format actual, expected
    
    PR-URL: #28878
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RamirezAlex authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    84efadf View commit details
    Browse the repository at this point in the history
  36. doc: correct import statement

    JSON file can be imported now
    
    PR-URL: #28876
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    himself65 authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    5533d48 View commit details
    Browse the repository at this point in the history
  37. doc: fixup esm resolver spec formatting

    PR-URL: #28885
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    guybedford authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    085eb48 View commit details
    Browse the repository at this point in the history
  38. src: read break_node_first_line from the inspect options

    There are cases where the debug_options() on the env are
    different to the options that were passed into inspector::Agent.
    
    PR-URL: #28034
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    MarshallOfSound authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    406c50c View commit details
    Browse the repository at this point in the history
  39. test: improve test-async-hooks-http-parser-destroy

    Improve asserts to distinguish between reequest and response parsers.
    
    Change the assert sequence to first assert on the number of ids to
    easier identify if some operation is missing/incomplete.
    
    Destroy HTTP agent once expected number of events have been seen to
    avoid waiting on socket timeouts.
    
    Refs: #28112
    
    PR-URL: #28253
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Flarna authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    2142b6d View commit details
    Browse the repository at this point in the history
  40. vm: increase code coverage of source_text_module.js

    PR-URL: #28350
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    kball authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    b282c85 View commit details
    Browse the repository at this point in the history
  41. deps: dlloads node static linked executable

    OpenSSL dlloads itself to prevent unloading, in case it might be
    dynamically loaded. However when linked statically this will lead to
    dloading the main executable.
    
    Refs: #21848 (comment)
    PR-URL: #28045
    Fixes: #27925
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lal12 authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    9b02f36 View commit details
    Browse the repository at this point in the history
  42. dgram: changed 'var' to 'let' and 'const'

    PR-URL: #28357
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mgochoa authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    9dfa636 View commit details
    Browse the repository at this point in the history
  43. src: fix OpenBSD build

    PR-URL: #28384
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    devnexen authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    1b0d67b View commit details
    Browse the repository at this point in the history
  44. http2: add constant to already destructured constants

    PR-URL: #28176
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    dnalborczyk authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d0d3149 View commit details
    Browse the repository at this point in the history
  45. http2: destructure constants from require call

    PR-URL: #28176
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    dnalborczyk authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    fa82cbc View commit details
    Browse the repository at this point in the history
  46. doc: add example of event close for child_process

    PR-URL: #28376
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ltciro authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    a28db5f View commit details
    Browse the repository at this point in the history
  47. src: readlink("/proc/self/exe") -> uv_exename()

    This commit also adds error handling. A THP-enabled build terminated
    with an out-of-memory error on a system without /proc because it cast
    the -1 from readlink() to size_t (i.e. ULONG_MAX) and then tried to
    allocate a string of that size.
    
    PR-URL: #28333
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bnoordhuis authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    32cf344 View commit details
    Browse the repository at this point in the history
  48. test: refactor test using assert instead of try/catch

    PR-URL: #28346
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    juansb827 authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    a0f89a2 View commit details
    Browse the repository at this point in the history
  49. test: udpate test comment description

    test-buffer-failed-alloc-typed-arrays.js is working fine, but the
    description was not correct.
    
    PR-URL: #28351
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Angelfire authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    9b47f77 View commit details
    Browse the repository at this point in the history
  50. benchmark: swap var for let in url benchmarks

    In benchmark url directory this changes for loops using var to let
    when it applies for consistency
    
    PR-URL: #28867
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RamirezAlex authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    048db38 View commit details
    Browse the repository at this point in the history
  51. benchmark: swap var for let in util benchmarks

    In benchmark util directory this changes for loops using var to let
    when it applies for consistency
    
    PR-URL: #28867
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RamirezAlex authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    f2c1f36 View commit details
    Browse the repository at this point in the history
  52. benchmark: swap var for let in buffer benchmarks

    In benchmark buffers directory this changes for loops using var to let
    when it applies for consistency
    
    PR-URL: #28867
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RamirezAlex authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    bbcf9f0 View commit details
    Browse the repository at this point in the history
  53. src: export v8.GetHeapCodeAndMetadataStatistics()

    Export statistic provided by V8 through HeapCodeStatistics class and
    and GetHeapCodeAndMetadataStatistics function to v8 Node.js module
    
    PR-URL: #27978
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Yuriy Vasiyarov authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    cce2087 View commit details
    Browse the repository at this point in the history
  54. build: do not mix spaces and tabs in Makefile

    PR-URL: #28881
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    fb57bc4 View commit details
    Browse the repository at this point in the history
  55. test: fix race in test-http2-origin

    PR-URL: #28903
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mildsunrise authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    31aa33b View commit details
    Browse the repository at this point in the history
  56. test: fix nits in test/fixtures/tls-connect.js

    PR-URL: #28880
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    19070e4 View commit details
    Browse the repository at this point in the history
  57. build: generate openssl config for BSD-x86

    Add BSD-x86 to the list of arches and regenerate everything.
    
    Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
    everything else is manual edits to include the right files in the
    right places.
    
    I cheated a little: I didn't check in changes to files for other arches
    because they contained mostly churn (updated buildstamps and such.)
    
    Fixes: #20326
    
    PR-URL: #28806
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    bnoordhuis authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    25aa222 View commit details
    Browse the repository at this point in the history
  58. src: large pages fix FreeBSD fix region size

    Makes the size aligned to huge page size by
    calculating it from the aligned lower and upper
    boundary of the executable address.
    
    PR-URL: #28735
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    devnexen authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    3d51d30 View commit details
    Browse the repository at this point in the history
  59. build: remove support for s390 (but not s390x)

    Upstream V8 removed support for s390 earlier this year and it's known
    to no longer build. Remove the support from our build scripts.
    
    Fixes: #28866
    PR-URL: #28883
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bnoordhuis authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    470db47 View commit details
    Browse the repository at this point in the history
  60. benchmark, http: refactor for code consistency

    In benchmark http directory this changes for loops using var to let
    when it applies for consistency
    
    PR-URL: #28791
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RamirezAlex authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    391fe46 View commit details
    Browse the repository at this point in the history
  61. lib: replace var with let in loaders.js

    PR-URL: #28081
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    mbj36 authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    464136f View commit details
    Browse the repository at this point in the history
  62. worker: handle calling terminate when kHandler is null

    This PR makes a change to the Worker.terminate() when called if the
    kHandler is null. Before this pull request it was returning undefined,
    but the API is expecting a promise. With the changes in this PR if
    terminate is called a Promise.resolve() is returned, unless a callback
    is passed in which case the old behavior stays (returns undefined).
    
    PR-URL: #28370
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    elyalvarado authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    43acce1 View commit details
    Browse the repository at this point in the history
  63. doc: add example about emitter.emit in events documentation

    PR-URL: #28374
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    felipedc09 authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    3e63429 View commit details
    Browse the repository at this point in the history
  64. test: use assert.throws() in test-require-json.js

    Use assert.throws() instead of try/catch.
    
    PR-URL: #28358
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    alejandronanez authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    b6e174b View commit details
    Browse the repository at this point in the history
  65. inspector: report all workers

    Main thread (the one that WS endpoint connects to) should be able
    to report all workers.
    
    PR-URL: #28872
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    eugeneo authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d72b682 View commit details
    Browse the repository at this point in the history
  66. doc: revoke DEP0089

    Using the legacy assert module is not discouraged. Revoke
    DEP0089 to avoid user confusion.
    
    PR-URL: #28892
    Fixes: #28780
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    cjihrig authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    5f07f49 View commit details
    Browse the repository at this point in the history
  67. module: unify package exports test for CJS and ESM

    Refs: nodejs/modules#358
    
    PR-URL: #28831
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jkrems authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d9084d2 View commit details
    Browse the repository at this point in the history
  68. src: allow generic C++ callables in SetImmediate()

    Modify the native `SetImmediate()` functions to take generic C++
    callables as arguments. This makes passing arguments to the callback
    easier, and in particular, it allows passing `std::unique_ptr`s
    directly, which in turn makes sure that the data they point to is
    deleted if the `Environment` is torn down before the callback can run.
    
    PR-URL: #28704
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d601a0a View commit details
    Browse the repository at this point in the history
  69. doc: include "exports" resolver specification

    PR-URL: #28899
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    guybedford authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    7c80963 View commit details
    Browse the repository at this point in the history
  70. n-api: refactoring napi_create_function testing

    This is a refactoring of #26998
    following #28505.
    
    The functions `add_last_status()` and `add_returned_status()` are now
    reused, see also #28848.
    
    PR-URL: #28894
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Octavian Soldea authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    c93df0c View commit details
    Browse the repository at this point in the history
  71. test: refactoring test_error testing

    PR-URL: #28902
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    himself65 authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    c42eb5d View commit details
    Browse the repository at this point in the history
  72. test: refactor test-beforeexit-event-exit using mustNotCall

    PR-URL: #28901
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    himself65 authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    efe9b97 View commit details
    Browse the repository at this point in the history
  73. build: include stubs in shared library

    This is needed for external applications that link to shared libnode.
    Fixes #27431
    
    PR-URL: #28897
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jeroen authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    dcef7b8 View commit details
    Browse the repository at this point in the history
  74. module: exports error as MODULE_NOT_FOUND

    PR-URL: #28905
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    guybedford authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    2236aff View commit details
    Browse the repository at this point in the history
  75. test: add tests for spaces in folder names

    Add tests for spaces in folder names for path.win32.dirname().
    
    PR-URL: #28819
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    PaulBags authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    c389526 View commit details
    Browse the repository at this point in the history
  76. doc: writableFinished is true before 'finish'

    PR-URL: #28811
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ronag authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    0ac6d28 View commit details
    Browse the repository at this point in the history
  77. doc: remove legacy mode deprecation in assert

    The deprecation was revoked in
    #28892.
    
    PR-URL: #28909
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    f4abf17 View commit details
    Browse the repository at this point in the history
  78. http2: destroy when settingsFn throws an error

    http2.connect should call destroy when init fails.
    
    PR-URL: #28908
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    himself65 authored and targos committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    7d9eb17 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. doc: fix sorting nit in sections of http.md

    PR-URL: #28943
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    vsemozhetbyt authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    57f5d50 View commit details
    Browse the repository at this point in the history
  2. report: include network interfaces in report

    PR-URL: #28911
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    4b91e4d View commit details
    Browse the repository at this point in the history
  3. test: refactor test-fs-stat.js

    General code cleanup.
    
    PR-URL: #28929
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    0f8f552 View commit details
    Browse the repository at this point in the history
  4. doc: describe NODE_OPTIONS interop w/cmd line opts

    Fixes #28910
    
    PR-URL: #28928
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    reasonablytall authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    bdd442f View commit details
    Browse the repository at this point in the history
  5. Revert "src: remove trace_sync_io_ from env"

    This reverts commit 7fa5f54.
    
    The reverted commit breaks the logic behind --trace-sync-io, it should
    be enabled only at a certain point in time, while that commit enables
    it from the very start, causing warnings be printed for all sync io
    instead of sync io after the first tick of the event loop as documented.
    
    Fixes: #28913
    Refs: #22726
    Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io
    PR-URL: #28926
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ChALkeR authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    4a747f6 View commit details
    Browse the repository at this point in the history
  6. net: shallow copy option when create Server

    PR-URL: #28924
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    himself65 authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    3c52dbe View commit details
    Browse the repository at this point in the history
  7. doc: remove use of you

    We generally avoid the use of 'you'.
    
    PR-URL: #28919
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mhdawson authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    02a50c3 View commit details
    Browse the repository at this point in the history
  8. path: improve normalization performance

    PR-URL: #28948
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    mscdex authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    1f82929 View commit details
    Browse the repository at this point in the history
  9. deps: upgrade npm to 6.10.2

    PR-URL: #28853
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    isaacs authored and BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    11470d5 View commit details
    Browse the repository at this point in the history
  10. 2019-08-06, Version 12.8.0 (Current)

    Notable changes:
    
    * assert:
      * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
        #28892
    * crypto:
      * The `outputLength` option is added to `crypto.createHash`
        (Tobias Nießen) #28805
      * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
        #28799
    * n-api:
      * Added APIs for per-instance state management (Gabriel Schulhof)
        #28682
    * report:
      * Network interfaces get included in the report (cjihrig)
        #28911
    * src:
      * `v8.getHeapCodeStatistics()` is now exported
        (Yuriy Vasiyarov) #27978
    
    PR-URL: #29017
    BridgeAR committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    77d8f0c View commit details
    Browse the repository at this point in the history