Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: implement runtime option --no-node-snapshot for debugging #28567

Closed
wants to merge 1 commit into from
Closed

src: implement runtime option --no-node-snapshot for debugging #28567

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jul 5, 2019 •
edited

Refs: #28558

I did not add any documentation for this flag - the intention is to dedicate it to debugging Node.js core, somewhat similar to --expose-internals and --inspect-brk-node.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 5, 2019
devsnek
devsnek approved these changes Jul 5, 2019
View reviewed changes
src/node_options.cc Outdated
@@ -368,6 +368,11 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
"silence all process warnings",
&EnvironmentOptions::no_warnings,
kAllowedInEnvironment);
AddOption("--no-node-snapshot",
"Launch Node.js without deserializing from the Node.js custom "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to mention it's an undocumented debug flag here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the warnings are alphabetical so this should go above --no-warnings?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, well, they aren't alphabetical, but they're mostly alphabetical?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… if this is supposed to be undocumented, I’d prefer not documenting it at all (i.e. no help text) over documenting that it’s undocumented, because the latter is pretty self-contradictory.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24290/

@Trott
Copy link
Member

Trott commented Jul 5, 2019

Is --no-snapshot sufficient?

@joyeecheung
Copy link
Member Author

@Trott That can be somewhat ambiguous because there is also the v8 default snapshot, we use --without-snapshot and --without-node-snapshot to distinguish between the two in the configure script.

addaleax
addaleax approved these changes Jul 6, 2019
View reviewed changes
src/node_options.cc Outdated
@@ -368,6 +368,11 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
"silence all process warnings",
&EnvironmentOptions::no_warnings,
kAllowedInEnvironment);
AddOption("--no-node-snapshot",
"Launch Node.js without deserializing from the Node.js custom "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… if this is supposed to be undocumented, I’d prefer not documenting it at all (i.e. no help text) over documenting that it’s undocumented, because the latter is pretty self-contradictory.

src/node.cc Outdated
std::vector<intptr_t> external_references;

bool force_no_snapshot =
per_process::cli_options->per_isolate->per_env->no_node_snapshot;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t really make sense as a per_env option though, right? More as a per-Isolate one?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24330/

@joyeecheung
Copy link
Member Author

Removed the help text and moved it into per-isolate options

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24333/

joyeecheung added a commit that referenced this pull request Jul 9, 2019
@joyeecheung
src: implement runtime option --no-node-snapshot for debugging
581bddc 
PR-URL: #28567
Refs: #28558
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@joyeecheung
Copy link
Member Author

Landed in 581bddc

targos pushed a commit that referenced this pull request Jul 20, 2019
@joyeecheung @targos
src: implement runtime option --no-node-snapshot for debugging
4f035e4 
PR-URL: #28567
Refs: #28558
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joyeecheung @nodejs-github-bot @Trott @addaleax @devsnek