src: restrict unloading addons to Worker threads #25577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
This was referenced Jan 18, 2019
Merged
|
CI: https://ci.nodejs.org/job/node-test-pull-request/20205/ (:heavy_check_mark:) Please 👍 this comment to approve fast-tracking – it fixes a regression in 11.7.0. |
cjihrig
approved these changes
Jan 19, 2019
addaleax
removed
the
fast-track
|
This needs a second review. (/cc @nodejs/workers maybe?) |
refack
previously approved these changes
Jan 21, 2019
refack
dismissed
their stale review
Code LGTM, but I don't feel knowledgeable enough in this area.
danbev
approved these changes
Jan 22, 2019
bnoordhuis
approved these changes
Jan 22, 2019
Unloading native addons from the main thread was an (presumably unintended) significant breaking change, because addons may rely on their memory being available after an `Environment` exits. This patch only restricts this to Worker threads, at least for the time being, and thus matches the behaviour from nodejs#23319. Refs: nodejs#24861 Refs: nodejs#23319
addaleax
force-pushed
the
addon-unload-main-thread
branch
from
a6186f8
to
d7d409a
Compare
|
@bnoordhuis Thanks, done! |
addaleax
added
the
author ready
|
Windows failure looks weird. Rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/24153/ (✔️ ) |
|
Landed in ef1c639. |
danbev
pushed a commit
that referenced
this pull request
Jan 23, 2019
Unloading native addons from the main thread was an (presumably unintended) significant breaking change, because addons may rely on their memory being available after an `Environment` exits. This patch only restricts this to Worker threads, at least for the time being, and thus matches the behaviour from #23319. PR-URL: #25577 Refs: #24861 Refs: #23319 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
added a commit
that referenced
this pull request
Jan 23, 2019
Unloading native addons from the main thread was an (presumably unintended) significant breaking change, because addons may rely on their memory being available after an `Environment` exits. This patch only restricts this to Worker threads, at least for the time being, and thus matches the behaviour from #23319. PR-URL: #25577 Refs: #24861 Refs: #23319 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unloading native addons from the main thread was an (presumably
unintended) significant breaking change, because addons may
rely on their memory being available after an
Environmentexits.This patch only restricts this to Worker threads, at least for the
time being, and thus matches the behaviour from #23319.
Refs: #24861
Refs: #23319
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes