Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes NODE_OPTIONS when spaces are escaped #24065

Closed
wants to merge 5 commits into from
Closed

Fixes NODE_OPTIONS when spaces are escaped #24065

wants to merge 5 commits into from
+55 −4

Commits on Apr 17, 2019

  1. src: allows escaping NODE_OPTIONS with backslashes 

    The characters specified within NODE_OPTIONS can now be escaped, which
is handy especially in conjunction with `--require` (where the file path
might happen to contain spaces that shouldn't cause the option to be
split into two).

Fixes: nodejs#12971
    @addaleax
    Maël Nison authored and addaleax committed Apr 17, 2019
    Copy the full SHA
    4025612 View commit details
    Browse the repository at this point in the history

  2. Switches to a basic json-like parsing

    @addaleax
    Maël Nison authored and addaleax committed Apr 17, 2019
    Copy the full SHA
    1d3d149 View commit details
    Browse the repository at this point in the history

  3. Fixes error return

    @addaleax
    Maël Nison authored and addaleax committed Apr 17, 2019
    Copy the full SHA
    b659b46 View commit details
    Browse the repository at this point in the history

  4. Updates the wording

    @arcanis @addaleax
    arcanis authored and addaleax committed Apr 17, 2019
    Copy the full SHA
    51481a3 View commit details
    Browse the repository at this point in the history

  5. fixup

    @addaleax
    addaleax committed Apr 17, 2019
    Copy the full SHA
    2516325 View commit details
    Browse the repository at this point in the history