fs: runtime deprecation for fs.SyncWriteStream #10467

jasnell · 2016-12-27T02:40:27Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

fs

Description of change

This API was never intended to be made public and was docs-only
deprecated in Node.js 6.x. This upgrades to a runtime deprecation
for Node.js 8.0.0

jasnell · 2016-12-30T01:29:02Z

@nodejs/ctc ... any objections to this?

ChALkeR · 2016-12-30T14:36:51Z

Per #6749 (comment), the most significant user of SyncWriteStream is the debug npm module.

I filed debug-js/debug#280 («fs.SyncWriteStream is pending removal») there back then, but, judging from the feedback, perhaps it's needed only for rare usage cases. I asked them a question in a comment, waiting for an answer.

I will run a search with newer data to see if there are other significant SyncWriteStream users.

In general, I'm +1 to runtime deprecation of SyncWriteStream in 8.0.

thefourtheye · 2017-01-02T08:09:10Z

Please note that this changes the file permission of fs.js, from 100644 to 100755

jasnell · 2017-01-03T16:46:50Z

grr.. yeah, was having some issues with the file permission config setting when I switched laptops and operating systems. Will get this fixed before landing.

thefourtheye

LGTM if CITGM and CI are happy.

jasnell · 2017-01-03T18:42:52Z

filemode edit fixed

jasnell · 2017-01-03T18:44:10Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/503/
CI: https://ci.nodejs.org/job/node-test-pull-request/5686/

evanlucas · 2017-01-03T19:10:11Z

-1 if this is being used by debug. That is used by like 80% of the entire ecosystem. Are we exposing something for them to use instead of this?

jasnell · 2017-01-03T19:15:19Z

No, the class was never intended to be made public and was never documented. The docs-only deprecation was added in v6 with the intention of upgrading it to a runtime deprecation. There is nothing to replace it with unless we want to reverse the deprecation and make it a fully supported API

evanlucas · 2017-01-03T19:26:04Z

Are we really going to add a runtime deprecation for a package that was downloaded 674,116 in the last day? It has 12,372 dependent (public) packages.

I'm -1 on this.

thefourtheye · 2017-01-03T19:37:58Z

@evanlucas Good call. FWIW debug-js/debug#406 removes the usage of SyncWriteStream

evanlucas · 2017-01-03T19:49:05Z

@thefourtheye I saw that. My concern with that is that it will be done in a major bump (which it should), but that doesn't mean that all of the dependent packages will go through and update to debug@3

jasnell · 2017-01-03T19:51:41Z

That is the whole point of runtime deprecations is it not? To strongly encourage developers to move up to the newer version that does not have the problem?

evanlucas · 2017-01-03T19:57:30Z

That is the whole point of runtime deprecations is it not? To strongly encourage developers to move up to the newer version that does not have the problem?

Sure. That doesn't mean that it works. We even talked about this at NINA. Not everyone will update, just like we saw with Buffer without new. IMO, regardless of whether the API was meant to be made public, it still was made public. Is it a security issue or a severe performance hindrance? If not, I find it very hard to justify breaking the ~~675k~~ 12k (public) packages that depend on it. What does deprecating this actually buy us?

addaleax · 2017-01-03T20:22:43Z

What does deprecating this actually buy us?

I agree, I don’t really see so far what we are gaining by adding a runtime deprecations or why the original intentions of adding the API have an influence on which changes we make. (I don’t want to repeat everything I said in #7964 (comment), but imho we should always have a reason for adding deprecations that goes beyond “This is the next step in our deprecation policy”.)

breaking the 675k (public) packages that depend on it

That’s downloads/day, it’s “just” 12k packages ;)

ChALkeR · 2017-01-03T20:51:09Z

@evanlucas judging from the debug code, that line was hit only in the cases when DEBUG_FD enviroment variable was specified to something other than 1 or 2 and tty_wrap.guessHandleType returned 'FILE' from that specified DEBUG_FD.

Note that specifing any DEBUG_FD enviroment variable now causes a runtime deprecation on the current version of the debug module (2.6.0), which got there in a semver-minor update of debug: debug-js/debug#405.

DEBUG_FD support is also removed in the next major version of debug.

evanlucas · 2017-01-05T13:40:05Z

@ChALkeR that is a fair point.

Seeing as it is about to be removed, can we at least wait to deprecate until after debug@3 has been released?

jasnell · 2017-01-05T14:58:12Z

Holding off a bit is fine, there's no rush to get this landed. It can even land after 8.x is released if necessary

jasnell · 2017-01-07T04:47:45Z

marking as blocked for the time being.

ChALkeR · 2017-01-07T07:58:21Z

I find it very hard to justify breaking the ~~675k~~ 12k (public) packages that depend on it.

This does not «break» those 12k public packages.

This will add a runtime warning to the DEBUG_FD=3 node script.js 3>debug.log usecase of those packages, which already shoots runtime deprecation warnings from the debug side, as of debug 2.6.0: https://github.com/visionmedia/debug/blob/2.6.0/src/node.js#L61-L63.

I don't see why exactly should we wait for debug 3.0 to deprecate this, as the current version of debug already has DEBUG_FD functionality runtime-deprecated.

evanlucas · 2017-01-30T15:26:00Z

@ChALkeR fair enough. Not sure why I had it set in my mind that it would.

evanlucas

LGTM. Sorry for making such a fuss about it :]

jasnell · 2017-02-22T22:56:02Z

Does one really need an excuse to use the squirrel?

jasnell · 2017-02-23T00:24:18Z

New CI before landing: https://ci.nodejs.org/job/node-test-pull-request/6556/

This API was never intended to be made public and was docs-only deprecated in Node.js 6.x. This upgrades to a runtime deprecation for Node.js 8.0.0 PR-URL: #10467 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

jasnell · 2017-02-23T01:09:32Z

Landed in 7a55e34 after green CI

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](nodejs@4a7233c178)] [nodejs#12892](nodejs#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](nodejs@d2d32ea5a2)] [nodejs#11968](nodejs#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](nodejs@7eb1b4658e)] [nodejs#12141](nodejs#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](nodejs@beca3244e2)] [nodejs#10236](nodejs#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](nodejs@97a77288ce)] [nodejs#12348](nodejs#12348), [[`d75fdd96aa`](nodejs@d75fdd96aa)] [nodejs#10423](nodejs#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](nodejs@627ecee9ed)] [nodejs#10653](nodejs#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](nodejs@f18e08d820)] [nodejs#9744](nodejs#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](nodejs@3c3b36af0f)] [nodejs#12936](nodejs#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](nodejs@60d1aac8d2)] [nodejs#12784](nodejs#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](nodejs@84dabe8373)] [nodejs#12489](nodejs#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](nodejs@7a55e34ef4)] [nodejs#10467](nodejs#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](nodejs@3c2a9361ff)] [nodejs#9683](nodejs#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](nodejs@90403dd1d0)] [nodejs#11567](nodejs#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](nodejs@d3480776c7)] [nodejs#11259](nodejs#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](nodejs@fb71ba4921)] [nodejs#11355](nodejs#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](nodejs@3e6f1032a4)] [nodejs#10805](nodejs#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](nodejs@5de3cf099c)] [nodejs#10116](nodejs#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](nodejs@84a23391f6)] [nodejs#12113](nodejs#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](nodejs@56e881d0b0)] [nodejs#11975](nodejs#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](nodejs@03e89b3ff2)] [nodejs#10116](nodejs#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](nodejs@dd20e68b0f)] [nodejs#12725](nodejs#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](nodejs@3f27f02da0)] [nodejs#11599](nodejs#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (nodejs@ec7cbaf266)] [nodejs#12995](nodejs#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](nodejs@a16b570f8c)] [nodejs#11968](nodejs#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](nodejs@010f864426)] [nodejs#12949](nodejs#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](nodejs@a5f91ab230)] [nodejs#11689](nodejs#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](nodejs@8a7db9d4b5)] [nodejs#12087](nodejs#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](nodejs@b6e1d22fa6)] [nodejs#12925](nodejs#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](nodejs@07c7f198db)] [nodejs#12828](nodejs#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](nodejs@348cc80a3c)] [nodejs#5923](nodejs#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](nodejs@a2ae08999b)] [nodejs#11349](nodejs#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](nodejs@d523eb9c40)] [nodejs#11447](nodejs#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](nodejs@d080ead0f9)] [nodejs#12710](nodejs#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](nodejs@5bfd13b81e)] [nodejs#9726](nodejs#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](nodejs@455e6f1dd8)] [nodejs#11708](nodejs#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](nodejs@aab0d202f8)] [nodejs#11624](nodejs#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](nodejs@99da8e8e02)] [nodejs#12442](nodejs#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](nodejs@91383e47fd)] [nodejs#12001](nodejs#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](nodejs@b514bd231e)] [nodejs#11391](nodejs#11391).

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](4a7233c178)] [#12892](#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](d2d32ea5a2)] [#11968](#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](7eb1b4658e)] [#12141](#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](beca3244e2)] [#10236](#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](97a77288ce)] [#12348](#12348), [[`d75fdd96aa`](d75fdd96aa)] [#10423](#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](627ecee9ed)] [#10653](#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](f18e08d820)] [#9744](#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](3c3b36af0f)] [#12936](#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](60d1aac8d2)] [#12784](#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](84dabe8373)] [#12489](#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](7a55e34ef4)] [#10467](#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](3c2a9361ff)] [#9683](#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](90403dd1d0)] [#11567](#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](d3480776c7)] [#11259](#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](fb71ba4921)] [#11355](#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](3e6f1032a4)] [#10805](#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](5de3cf099c)] [#10116](#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](84a23391f6)] [#12113](#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](56e881d0b0)] [#11975](#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](03e89b3ff2)] [#10116](#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](dd20e68b0f)] [#12725](#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](3f27f02da0)] [#11599](#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (ec7cbaf266)] [#12995](#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](a16b570f8c)] [#11968](#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](010f864426)] [#12949](#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](a5f91ab230)] [#11689](#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](8a7db9d4b5)] [#12087](#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](b6e1d22fa6)] [#12925](#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](07c7f198db)] [#12828](#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](348cc80a3c)] [#5923](#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](a2ae08999b)] [#11349](#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](d523eb9c40)] [#11447](#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](d080ead0f9)] [#12710](#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](5bfd13b81e)] [#9726](#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](455e6f1dd8)] [#11708](#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](aab0d202f8)] [#11624](#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](99da8e8e02)] [#12442](#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](91383e47fd)] [#12001](#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](b514bd231e)] [#11391](#11391).

jasnell added ctc-review fs Issues and PRs related to the fs subsystem / file system. semver-major PRs that contain breaking changes and should be released in the next major version. labels Dec 27, 2016

nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Dec 27, 2016

targos approved these changes Dec 27, 2016

View reviewed changes

cjihrig approved these changes Dec 28, 2016

View reviewed changes

thefourtheye approved these changes Jan 3, 2017

View reviewed changes

jasnell force-pushed the runtime-deprecate-syncwritestream branch from 19c081a to d1be63b Compare January 3, 2017 18:42

jasnell added the blocked PRs that are blocked by other issues or PRs. label Jan 7, 2017

evanlucas approved these changes Jan 30, 2017

View reviewed changes

jasnell closed this Feb 23, 2017

jasnell mentioned this pull request Apr 4, 2017

8.0.0 Release Proposal #12220

Closed

Lizhooh mentioned this pull request Jun 7, 2017

fs.SyncWriteStream is deprecated [Nodejs v8.0] hexojs/hexo#2598

Closed

xovel mentioned this pull request Dec 31, 2017

[hexo]升级 - 解决 fs.SyncWriteStream 废弃引发的警告 xovel/xovel.github.io#28

Open

tniessen added the deprecations Issues and PRs related to deprecations. label Sep 7, 2018

snyk-bot mentioned this pull request Apr 24, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#97

Open

aliscco mentioned this pull request Apr 24, 2023

[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#109

Open

This was referenced Apr 24, 2023

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#122

Open

[Snyk] Fix for 17 vulnerabilities aliscco/alisco-node#127

Open

aliscco mentioned this pull request Apr 24, 2023

[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#128

Open

This was referenced Apr 25, 2023

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#177

Open

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#182

Open

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#183

Open

aliscco mentioned this pull request Apr 26, 2023

[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#195

Open

snyk-bot mentioned this pull request Apr 26, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#249

Open

aliscco mentioned this pull request Apr 28, 2023

[Snyk] Fix for 10 vulnerabilities aliscco/alisco-node#309

Open

snyk-bot mentioned this pull request Apr 28, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#336

Open

aliscco mentioned this pull request Apr 29, 2023

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#356

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: runtime deprecation for fs.SyncWriteStream #10467

fs: runtime deprecation for fs.SyncWriteStream #10467

jasnell commented Dec 27, 2016

jasnell commented Dec 30, 2016

ChALkeR commented Dec 30, 2016 •

edited

thefourtheye commented Jan 2, 2017

jasnell commented Jan 3, 2017

thefourtheye left a comment

jasnell commented Jan 3, 2017

jasnell commented Jan 3, 2017 •

edited

evanlucas commented Jan 3, 2017

jasnell commented Jan 3, 2017

evanlucas commented Jan 3, 2017

thefourtheye commented Jan 3, 2017

evanlucas commented Jan 3, 2017

jasnell commented Jan 3, 2017

evanlucas commented Jan 3, 2017 •

edited

addaleax commented Jan 3, 2017

ChALkeR commented Jan 3, 2017 •

edited

evanlucas commented Jan 5, 2017 •

edited

jasnell commented Jan 5, 2017

jasnell commented Jan 7, 2017

ChALkeR commented Jan 7, 2017

evanlucas commented Jan 30, 2017

evanlucas left a comment

jasnell commented Feb 22, 2017

jasnell commented Feb 23, 2017

jasnell commented Feb 23, 2017

fs: runtime deprecation for fs.SyncWriteStream #10467

fs: runtime deprecation for fs.SyncWriteStream #10467

Conversation

jasnell commented Dec 27, 2016

Checklist

Affected core subsystem(s)

Description of change

jasnell commented Dec 30, 2016

ChALkeR commented Dec 30, 2016 • edited

thefourtheye commented Jan 2, 2017

jasnell commented Jan 3, 2017

thefourtheye left a comment

Choose a reason for hiding this comment

jasnell commented Jan 3, 2017

jasnell commented Jan 3, 2017 • edited

evanlucas commented Jan 3, 2017

jasnell commented Jan 3, 2017

evanlucas commented Jan 3, 2017

thefourtheye commented Jan 3, 2017

evanlucas commented Jan 3, 2017

jasnell commented Jan 3, 2017

evanlucas commented Jan 3, 2017 • edited

addaleax commented Jan 3, 2017

ChALkeR commented Jan 3, 2017 • edited

evanlucas commented Jan 5, 2017 • edited

jasnell commented Jan 5, 2017

jasnell commented Jan 7, 2017

ChALkeR commented Jan 7, 2017

evanlucas commented Jan 30, 2017

evanlucas left a comment

Choose a reason for hiding this comment

jasnell commented Feb 22, 2017

jasnell commented Feb 23, 2017

jasnell commented Feb 23, 2017

ChALkeR commented Dec 30, 2016 •

edited

jasnell commented Jan 3, 2017 •

edited

evanlucas commented Jan 3, 2017 •

edited

ChALkeR commented Jan 3, 2017 •

edited

evanlucas commented Jan 5, 2017 •

edited