lib: enforce ASCII order in error code imports

PR-URL: #52625 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
nodejs · Apr 23, 2024 · 231548b · 231548b
1 parent ff82606
commit 231548b
Show file tree

Hide file tree

Showing 59 changed files with 268 additions and 168 deletions.
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -185,6 +185,7 @@ rules:
     - groups: [['&&', '||']]
 
   # Custom rules in tools/eslint-rules
+  node-core/alphabetize-errors: error
   node-core/alphabetize-primordials: error
   node-core/avoid-prototype-pollution: error
   node-core/lowercase-name-for-primitive: error

diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -72,14 +72,16 @@ const {
   traceEnd,
   getNextTraceEventId,
 } = require('internal/http');
-const { ConnResetException, codes } = require('internal/errors');
 const {
-  ERR_HTTP_HEADERS_SENT,
-  ERR_INVALID_ARG_TYPE,
-  ERR_INVALID_HTTP_TOKEN,
-  ERR_INVALID_PROTOCOL,
-  ERR_UNESCAPED_CHARACTERS,
-} = codes;
+  ConnResetException,
+  codes: {
+    ERR_HTTP_HEADERS_SENT,
+    ERR_INVALID_ARG_TYPE,
+    ERR_INVALID_HTTP_TOKEN,
+    ERR_INVALID_PROTOCOL,
+    ERR_UNESCAPED_CHARACTERS,
+  },
+} = require('internal/errors');
 const {
   validateInteger,
   validateBoolean,

diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -56,21 +56,21 @@ const {
 } = require('internal/async_hooks');
 const {
   codes: {
+    ERR_HTTP_BODY_NOT_ALLOWED,
     ERR_HTTP_CONTENT_LENGTH_MISMATCH,
     ERR_HTTP_HEADERS_SENT,
     ERR_HTTP_INVALID_HEADER_VALUE,
     ERR_HTTP_TRAILER_INVALID,
-    ERR_HTTP_BODY_NOT_ALLOWED,
-    ERR_INVALID_HTTP_TOKEN,
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_ARG_VALUE,
     ERR_INVALID_CHAR,
+    ERR_INVALID_HTTP_TOKEN,
     ERR_METHOD_NOT_IMPLEMENTED,
-    ERR_STREAM_CANNOT_PIPE,
     ERR_STREAM_ALREADY_FINISHED,
-    ERR_STREAM_WRITE_AFTER_END,
-    ERR_STREAM_NULL_VALUES,
+    ERR_STREAM_CANNOT_PIPE,
     ERR_STREAM_DESTROYED,
+    ERR_STREAM_NULL_VALUES,
+    ERR_STREAM_WRITE_AFTER_END,
   },
   hideStackFrames,
 } = require('internal/errors');

diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -70,17 +70,17 @@ const {
 const { IncomingMessage } = require('_http_incoming');
 const {
   ConnResetException,
-  codes,
+  codes: {
+    ERR_HTTP_HEADERS_SENT,
+    ERR_HTTP_INVALID_STATUS_CODE,
+    ERR_HTTP_REQUEST_TIMEOUT,
+    ERR_HTTP_SOCKET_ASSIGNED,
+    ERR_HTTP_SOCKET_ENCODING,
+    ERR_INVALID_ARG_VALUE,
+    ERR_INVALID_CHAR,
+    ERR_OUT_OF_RANGE,
+  },
 } = require('internal/errors');
-const {
-  ERR_HTTP_REQUEST_TIMEOUT,
-  ERR_HTTP_HEADERS_SENT,
-  ERR_HTTP_INVALID_STATUS_CODE,
-  ERR_HTTP_SOCKET_ENCODING,
-  ERR_HTTP_SOCKET_ASSIGNED,
-  ERR_INVALID_ARG_VALUE,
-  ERR_INVALID_CHAR,
-} = codes;
 const {
   kEmptyObject,
   promisify,
@@ -467,7 +467,7 @@ function storeHTTPOptions(options) {
   }
 
   if (this.requestTimeout > 0 && this.headersTimeout > 0 && this.headersTimeout > this.requestTimeout) {
-    throw new codes.ERR_OUT_OF_RANGE('headersTimeout', '<= requestTimeout', headersTimeout);
+    throw new ERR_OUT_OF_RANGE('headersTimeout', '<= requestTimeout', headersTimeout);
   }
 
   const keepAliveTimeout = options.keepAliveTimeout;

diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -66,23 +66,25 @@ const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap');
 const { owner_symbol } = require('internal/async_hooks').symbols;
 const { isArrayBufferView } = require('internal/util/types');
 const { SecureContext: NativeSecureContext } = internalBinding('crypto');
-const { ConnResetException, codes } = require('internal/errors');
 const {
-  ERR_INVALID_ARG_TYPE,
-  ERR_INVALID_ARG_VALUE,
-  ERR_MULTIPLE_CALLBACK,
-  ERR_SOCKET_CLOSED,
-  ERR_TLS_ALPN_CALLBACK_INVALID_RESULT,
-  ERR_TLS_ALPN_CALLBACK_WITH_PROTOCOLS,
-  ERR_TLS_DH_PARAM_SIZE,
-  ERR_TLS_HANDSHAKE_TIMEOUT,
-  ERR_TLS_INVALID_CONTEXT,
-  ERR_TLS_RENEGOTIATION_DISABLED,
-  ERR_TLS_REQUIRED_SERVER_NAME,
-  ERR_TLS_SESSION_ATTACK,
-  ERR_TLS_SNI_FROM_SERVER,
-  ERR_TLS_INVALID_STATE,
-} = codes;
+  ConnResetException,
+  codes: {
+    ERR_INVALID_ARG_TYPE,
+    ERR_INVALID_ARG_VALUE,
+    ERR_MULTIPLE_CALLBACK,
+    ERR_SOCKET_CLOSED,
+    ERR_TLS_ALPN_CALLBACK_INVALID_RESULT,
+    ERR_TLS_ALPN_CALLBACK_WITH_PROTOCOLS,
+    ERR_TLS_DH_PARAM_SIZE,
+    ERR_TLS_HANDSHAKE_TIMEOUT,
+    ERR_TLS_INVALID_CONTEXT,
+    ERR_TLS_INVALID_STATE,
+    ERR_TLS_RENEGOTIATION_DISABLED,
+    ERR_TLS_REQUIRED_SERVER_NAME,
+    ERR_TLS_SESSION_ATTACK,
+    ERR_TLS_SNI_FROM_SERVER,
+  },
+} = require('internal/errors');
 const { onpskexchange: kOnPskExchange } = internalBinding('symbols');
 const {
   getOptionValue,

diff --git a/lib/buffer.js b/lib/buffer.js
@@ -103,8 +103,8 @@ const {
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_ARG_VALUE,
     ERR_INVALID_BUFFER_SIZE,
-    ERR_OUT_OF_RANGE,
     ERR_MISSING_ARGS,
+    ERR_OUT_OF_RANGE,
     ERR_UNKNOWN_ENCODING,
   },
   genericNodeError,

diff --git a/lib/child_process.js b/lib/child_process.js
@@ -64,16 +64,15 @@ const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap');
 
 const {
   AbortError,
-  codes: errorCodes,
+  codes: {
+    ERR_CHILD_PROCESS_IPC_REQUIRED,
+    ERR_CHILD_PROCESS_STDIO_MAXBUFFER,
+    ERR_INVALID_ARG_TYPE,
+    ERR_INVALID_ARG_VALUE,
+    ERR_OUT_OF_RANGE,
+  },
   genericNodeError,
 } = require('internal/errors');
-const {
-  ERR_INVALID_ARG_VALUE,
-  ERR_CHILD_PROCESS_IPC_REQUIRED,
-  ERR_CHILD_PROCESS_STDIO_MAXBUFFER,
-  ERR_INVALID_ARG_TYPE,
-  ERR_OUT_OF_RANGE,
-} = errorCodes;
 const { clearTimeout, setTimeout } = require('timers');
 const { getValidatedPath } = require('internal/fs/utils');
 const {

diff --git a/lib/dgram.js b/lib/dgram.js
@@ -34,24 +34,27 @@ const {
   SymbolDispose,
 } = primordials;
 
-const errors = require('internal/errors');
+const {
+  ErrnoException,
+  ExceptionWithHostPort,
+  codes: {
+    ERR_BUFFER_OUT_OF_BOUNDS,
+    ERR_INVALID_ARG_TYPE,
+    ERR_INVALID_FD_TYPE,
+    ERR_MISSING_ARGS,
+    ERR_SOCKET_ALREADY_BOUND,
+    ERR_SOCKET_BAD_BUFFER_SIZE,
+    ERR_SOCKET_BUFFER_SIZE,
+    ERR_SOCKET_DGRAM_IS_CONNECTED,
+    ERR_SOCKET_DGRAM_NOT_CONNECTED,
+    ERR_SOCKET_DGRAM_NOT_RUNNING,
+  },
+} = require('internal/errors');
 const {
   kStateSymbol,
   _createSocketHandle,
   newHandle,
 } = require('internal/dgram');
-const {
-  ERR_BUFFER_OUT_OF_BOUNDS,
-  ERR_INVALID_ARG_TYPE,
-  ERR_MISSING_ARGS,
-  ERR_SOCKET_ALREADY_BOUND,
-  ERR_SOCKET_BAD_BUFFER_SIZE,
-  ERR_SOCKET_BUFFER_SIZE,
-  ERR_SOCKET_DGRAM_IS_CONNECTED,
-  ERR_SOCKET_DGRAM_NOT_CONNECTED,
-  ERR_SOCKET_DGRAM_NOT_RUNNING,
-  ERR_INVALID_FD_TYPE,
-} = errors.codes;
 const {
   isInt32,
   validateAbortSignal,
@@ -97,11 +100,6 @@ function lazyLoadCluster() {
   return _cluster;
 }
 
-const {
-  ErrnoException,
-  ExceptionWithHostPort,
-} = errors;
-
 function Socket(type, listener) {
   FunctionPrototypeCall(EventEmitter, this);
   let lookup;

diff --git a/lib/dns.js b/lib/dns.js
@@ -31,12 +31,12 @@ const cares = internalBinding('cares_wrap');
 const { isIP } = require('internal/net');
 const { customPromisifyArgs } = require('internal/util');
 const {
+  DNSException,
   codes: {
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_ARG_VALUE,
     ERR_MISSING_ARGS,
   },
-  DNSException,
 } = require('internal/errors');
 const {
   bindDefaultResolver,

diff --git a/lib/events.js b/lib/events.js
@@ -66,13 +66,13 @@ let kResistStopPropagation;
 
 const {
   AbortError,
-  kEnhanceStackBeforeInspector,
   codes: {
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_THIS,
     ERR_UNHANDLED_ERROR,
   },
   genericNodeError,
+  kEnhanceStackBeforeInspector,
 } = require('internal/errors');
 
 const {

diff --git a/lib/fs.js b/lib/fs.js
@@ -70,13 +70,13 @@ const { Buffer } = require('buffer');
 const { isBuffer: BufferIsBuffer } = Buffer;
 const BufferToString = uncurryThis(Buffer.prototype.toString);
 const {
+  AbortError,
   aggregateTwoErrors,
   codes: {
     ERR_ACCESS_DENIED,
     ERR_FS_FILE_TOO_LARGE,
     ERR_INVALID_ARG_VALUE,
   },
-  AbortError,
 } = require('internal/errors');
 
 const {

diff --git a/lib/internal/assert/calltracker.js b/lib/internal/assert/calltracker.js
@@ -14,8 +14,8 @@ const {
 
 const {
   codes: {
-    ERR_UNAVAILABLE_DURING_EXIT,
     ERR_INVALID_ARG_VALUE,
+    ERR_UNAVAILABLE_DURING_EXIT,
   },
 } = require('internal/errors');
 const AssertionError = require('internal/assert/assertion_error');

diff --git a/lib/internal/blob.js b/lib/internal/blob.js
@@ -56,11 +56,11 @@ const { inspect } = require('internal/util/inspect');
 
 const {
   codes: {
+    ERR_BUFFER_TOO_LARGE,
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_ARG_VALUE,
-    ERR_INVALID_THIS,
     ERR_INVALID_STATE,
-    ERR_BUFFER_TOO_LARGE,
+    ERR_INVALID_THIS,
   },
 } = require('internal/errors');
 

diff --git a/lib/internal/bootstrap/switches/does_not_own_process_state.js b/lib/internal/bootstrap/switches/does_not_own_process_state.js
@@ -23,7 +23,9 @@ if (credentials.implementsPosixCredentials) {
 // ----              compare the setups side-by-side                    -----
 
 const {
-  codes: { ERR_WORKER_UNSUPPORTED_OPERATION },
+  codes: {
+    ERR_WORKER_UNSUPPORTED_OPERATION,
+  },
 } = require('internal/errors');
 
 function wrappedUmask(mask) {

diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -40,12 +40,12 @@ const {
 
 const { trace } = internalBinding('trace_events');
 const {
-  isStackOverflowError,
   codes: {
     ERR_CONSOLE_WRITABLE_STREAM,
-    ERR_INVALID_ARG_VALUE,
     ERR_INCOMPATIBLE_OPTION_PAIR,
+    ERR_INVALID_ARG_VALUE,
   },
+  isStackOverflowError,
 } = require('internal/errors');
 const {
   validateArray,

diff --git a/lib/internal/crypto/keys.js b/lib/internal/crypto/keys.js
@@ -35,8 +35,8 @@ const {
 const {
   codes: {
     ERR_CRYPTO_INCOMPATIBLE_KEY_OPTIONS,
-    ERR_CRYPTO_INVALID_KEY_OBJECT_TYPE,
     ERR_CRYPTO_INVALID_JWK,
+    ERR_CRYPTO_INVALID_KEY_OBJECT_TYPE,
     ERR_ILLEGAL_CONSTRUCTOR,
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_ARG_VALUE,

diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -40,8 +40,8 @@ const { Buffer, kMaxLength } = require('buffer');
 const {
   codes: {
     ERR_INVALID_ARG_TYPE,
-    ERR_OUT_OF_RANGE,
     ERR_OPERATION_FAILED,
+    ERR_OUT_OF_RANGE,
   },
 } = require('internal/errors');
 

diff --git a/lib/internal/crypto/util.js b/lib/internal/crypto/util.js
@@ -43,14 +43,14 @@ const {
 const normalizeHashName = require('internal/crypto/hashnames');
 
 const {
-  hideStackFrames,
   codes: {
     ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED,
     ERR_CRYPTO_ENGINE_UNKNOWN,
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_ARG_VALUE,
     ERR_OUT_OF_RANGE,
   },
+  hideStackFrames,
 } = require('internal/errors');
 
 const {

diff --git a/lib/internal/dgram.js b/lib/internal/dgram.js
@@ -5,17 +5,16 @@ const {
   Symbol,
 } = primordials;
 
-const { codes } = require('internal/errors');
+const { codes: {
+  ERR_SOCKET_BAD_TYPE,
+} } = require('internal/errors');
 const { UDP } = internalBinding('udp_wrap');
 const { guessHandleType } = require('internal/util');
 const {
   isInt32,
   validateFunction,
 } = require('internal/validators');
 const { UV_EINVAL } = internalBinding('uv');
-const {
-  ERR_SOCKET_BAD_TYPE,
-} = codes;
 const kStateSymbol = Symbol('state symbol');
 let dns;  // Lazy load for startup performance.
 

diff --git a/lib/internal/dns/callback_resolver.js b/lib/internal/dns/callback_resolver.js
@@ -8,11 +8,11 @@ const {
 } = primordials;
 
 const {
+  DNSException,
   codes: {
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_ARG_VALUE,
   },
-  DNSException,
 } = require('internal/errors');
 
 const {