Skip to content

tools: prepare custom rules for ESLint v9 #56276

tools: prepare custom rules for ESLint v9

tools: prepare custom rules for ESLint v9 #56276

Triggered via pull request May 8, 2024 10:11
Status Failure
Total duration 42m 20s
Artifacts

test-linux.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors
test-linux: test/parallel/test-eslint-prefer-primordials.js#L1
--- stderr --- /home/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:458 throw err; ^ Error: rule-tester: Configuration for rule "prefer-primordials" is invalid: Value [] should NOT have fewer than 1 items. at validateRuleOptions (/home/runner/work/node/node/tools/node_modules/eslint/lib/shared/config-validator.js:151:19) at /home/runner/work/node/node/tools/node_modules/eslint/lib/shared/config-validator.js:206:9 at Array.forEach (<anonymous>) at validateRules (/home/runner/work/node/node/tools/node_modules/eslint/lib/shared/config-validator.js:203:30) at validate (/home/runner/work/node/node/tools/node_modules/eslint/lib/shared/config-validator.js:300:5) at runRuleForItem (/home/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:812:13) at testValidTemplate (/home/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:896:28) at RuleTester.<anonymous> (/home/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:1181:33) at RuleTester.itDefaultHandler (/home/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:453:23) at /home/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:1178:71 Node.js v23.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-eslint-prefer-primordials.js
test-linux: test/parallel/test-eslint-prefer-proto.js#L1
--- stderr --- /home/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:458 throw err; ^ TypeError: Missing required argument: node. Occurred while linting <input>:1 Rule: "prefer-common-mustsucceed" at SourceCode.getScope (/home/runner/work/node/node/tools/node_modules/eslint/lib/source-code/source-code.js:773:19) at declaredScope (/home/runner/work/node/node/tools/eslint-rules/prefer-proto.js:11:41) at CallExpression[arguments.length=1]:matches( [callee.type="Identifier"][callee.name="ObjectCreate"], [callee.type="MemberExpression"][callee.object.name="Object"][callee.property.name="create"] ) (/home/runner/work/node/node/tools/eslint-rules/prefer-proto.js:36:25) at ruleErrorHandler (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/linter.js:1076:28) at /home/runner/work/node/node/tools/node_modules/eslint/lib/linter/safe-emitter.js:45:58 at Array.forEach (<anonymous>) at Object.emit (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/safe-emitter.js:45:38) at NodeEventGenerator.applySelector (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/node-event-generator.js:297:26) at NodeEventGenerator.applySelectors (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/node-event-generator.js:326:22) at NodeEventGenerator.enterNode (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/node-event-generator.js:340:14) { ruleId: 'prefer-common-mustsucceed', currentNode: <ref *2> Node { type: 'CallExpression', loc: SourceLocation { start: Position { line: 1, column: 0 }, end: Position { line: 1, column: 19 } }, range: [ 0, 19 ], callee: <ref *1> Node { type: 'MemberExpression', loc: SourceLocation { start: Position { line: 1, column: 0 }, end: Position { line: 1, column: 13 } }, range: [ 0, 13 ], object: Node { type: 'Identifier', loc: SourceLocation { start: Position { line: 1, column: 0 }, end: Position { line: 1, column: 6 } }, range: [ 0, 6 ], name: 'Object', parent: [Circular *1] }, property: Node { type: 'Identifier', loc: SourceLocation { start: Position { line: 1, column: 7 }, end: Position { line: 1, column: 13 } }, range: [ 7, 13 ], name: 'create', parent: [Circular *1] }, computed: false, optional: false, parent: [Circular *2] }, arguments: [ Node { type: 'Literal', loc: SourceLocation { start: Position { line: 1, column: 14 }, end: Position { line: 1, column: 18 } }, range: [ 14, 18 ], value: null, raw: 'null', parent: [Circular *2] } ], optional: false, parent: <ref *3> Node { type: 'ExpressionStatement', loc: SourceLocation { start: Position { line: 1, column: 0 }, end: Position { line: 1, column: 19 } }, range: [ 0, 19 ], expression: [Circular *2], parent: Node { type: 'Program', loc: SourceLocation { start: Position { line: 1, column: 0 }, end: Position { line: 1, column: 19 } }, range: [ 0, 19 ], body: [ [Circular *3] ], sourceType: 'script', comments: [], tokens: [ Token { type: 'Identifier', value: 'Object', loc: [SourceLocation], range: [Array] }, Token { type: 'Punctuator', value: '.', loc: [SourceLocation], range: [Array] }, Token { type: 'Identifier', value: 'create', loc: [SourceLocation], range: [Array] }, Token { type: 'Punctuator', value: '(', loc: [SourceLocation], range: [Array]
test-linux
Process completed with exit code 2.