This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are versions of V8 that don't define V8_MAJOR_VERSION?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not in any versions of Node.js this module has ever supported. It may be true in long outdated versions of Node.js (e.g.
deps/v8/include/v8-version.h
(whereV8_MAJOR_VERSION
is currently defined) doesn't exist in Node.js'v0.10
branch).For reference,
nan
does similar checks: https://github.com/nodejs/nan/blob/19f08c2394b19a5dbe854020fed0446606d68955/nan.h#L215-L216