Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v5.0.1 #1785

Merged
merged 0 commits into from Jun 21, 2019
Merged

Release proposal: v5.0.1 #1785

merged 0 commits into from Jun 21, 2019

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 20, 2019

The Electron 3 thing is the only major thing in here and controversy there is resolved. I'll publish this in 24 hours unless there are any objections.

  • [e3861722ed] - doc: document --jobs max (David Sanders) #1770
  • [1cfdb28886] - lib: reintroduce support for iojs file naming for releases >= 1 && < 4 (Samuel Attard) #1777

/cc @MarshallOfSound

@rvagg rvagg merged commit a757239 into master Jun 21, 2019
@rvagg rvagg deleted the rvagg/5.0.1-proposal branch June 21, 2019 02:27
@rvagg
Copy link
Member Author

rvagg commented Jun 21, 2019

published

@Curtis-D
Copy link

Did you re base the branch? I'm missing commit "8b7fdd1fc409029dce248bf543cd7060965539a9"

@rvagg
Copy link
Member Author

rvagg commented Jun 22, 2019

@Curtis-D I just pushed out those two commits for a 5.0.1, simply to get them out and deal with the Electron 3 thing. I've queued up a 5.0.2 in #1792, that should go out next week. My release process was a bit messed up and I had to rebase master so 8b7fdd1 became 2761afb and it's in the 5.0.2 list as such.

I'm still trying to figure out the best strategy for releases and branching here that optimises for more regular releases while also allowing for maintenance of older release lines. I've been wanting to avoid a special 5.x branch that cherry-picks from master, like on nodejs/node, because it's going to lead to branch-rot here since there's much less activity and maintenance. But doing it all on master is going to lead to regular rebases unless we put a pause on merges in the lead up to a release—which might not be a big deal if "lead up" is only a day's pause while a release proposal gets reviews. Or, we could just be OK with occasional master tip rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants