gyp: move compile_commands_json #1661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't possible to access `tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the `--format` option. This commit moves the file in a place where it can be accessed. Fixes: nodejs#1526 Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
|
If I missed something and this change isn't actually required, please tell me :) |
bnoordhuis
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
LGTM, thanks.
In case you're wondering: this file was brought over from nodejs/node@3c46bb9931 where gyp lives in tools/gyp. :-)
bnoordhuis
pushed a commit
that referenced
this pull request
Feb 12, 2019
It isn't possible to access `tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the `--format` option. This commit moves the file in a place where it can be accessed. Fixes: #1526 PR-URL: #1661 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
|
Landed in 2349dba, thanks Paul. |
rvagg
pushed a commit
that referenced
this pull request
Apr 24, 2019
It isn't possible to access `tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the `--format` option. This commit moves the file in a place where it can be accessed. Fixes: #1526 PR-URL: #1661 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't possible to access
tools/gyp/pylib/gyp/generator/compile_commands_json.pyusing the--formatoption.This commit moves the file in a place where it can be accessed.
Fixes: #1526
Signed-off-by: Paul Maréchal paul.marechal@ericsson.com
Checklist
npm install && npm testpassesDescription of change
Should allow us to use the
compile_commands_jsonformatter/generator.