Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of missing python on Windows. #1325

Closed
wants to merge 11 commits into from

Commits on Jun 6, 2017

  1. Upgrade to tar v3

    Tar version 3 performs better and is more well tested than its
    predecessor.  npm will be using this in the near future, so there is no
    benefit in shipping a node-gyp that uses the slower and less reliable
    fstream-based tar.
    
    This drops support for node 0.x, and thus should be considered a
    breaking semver-major change.
    
    PR-URL: nodejs#1212
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    isaacs authored and refack committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    5f924ce View commit details
    Browse the repository at this point in the history
  2. bump to v4.0.0

    * dropping support for node < 4
    * signal the CI not to test node < 4
    refack committed Jun 6, 2017
    4 Configuration menu
    Copy the full SHA
    75cfae2 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2017

  1. configure: don't set ensure if tarball is set

    If you're providing a path to a header tarball to install, you probably
    want it to always be re-installed.
    
    PR-URL: nodejs#1220
    Fixes: nodejs#1216
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    gibfahn committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    c84a541 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2017

  1. gyp: update xml string encoding conversion

    * test: build simple addon in path with non-ascii characters
    * test: add test-charmap.py
    
    PR-URL: nodejs#1203
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    lc-soft authored and refack committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    d6139b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2017

  1. doc: headerify the Install instructions

    Enable linking to the platform specific installation instructions
    
    PR-URL: nodejs#1225
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    nschonni authored and refack committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    35e1dbb View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2017

  1. doc: update proposed DCO and CoC

    Lifted verbatim from
    https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
    then `s/Node.js/node-gyp/`.
    
    PR-URL: nodejs#1229
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    mikeal authored and gibfahn committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    2e40fad View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2017

  1. doc: add github PR and Issue templates

    Give users reporting bugs a clearer idea of the info that will be
    helpful when reporting issues.
    
    PR-URL: nodejs#1228
    Refs: https://github.com/nodejs/node/tree/master/.github
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    gibfahn committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    7245415 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2017

  1. win: run PS with -NoProfile

    PR-URL: nodejs#1292
    Refs: nodejs#1195 (comment)
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    refack committed Sep 19, 2017
    1 Configuration menu
    Copy the full SHA
    63f43c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. zos: support platform

    Initial work to add z/OS support to node-gyp.
    
    
    PR-URL: nodejs#1276
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jBarz authored and gibfahn committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    a8ba528 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2017

  1. Fix IndexError when parsing GYP files.

    GYP automatically turns variables ending in _dir, _file or _path into
    absolute paths but didn't check for empty strings.
    
    It interacted badly with variables inherited through the environment
    from npm, the `scripts-prepend-node-path=false` setting in particular
    because it is turned into `npm_config_script_prepend_node_path=`.
    
    Fixes: nodejs#1217
    PR-URL: nodejs#1267
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    bnoordhuis committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    05d2002 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2017

  1. Fixed handling of missing python on Windows. Two problems. 1. invalid…

    … error message when python is found but invalid version (error returned: file not found with valid file path, expected: invalid python version). 2. in case of invalid version on guessed path (python27) it goes into an endless loop (unlikely but an ugly error)
    mvidmar committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    323a00f View commit details
    Browse the repository at this point in the history