win: add an arch check to VS 2019 (#3025)

nodejs · Apr 23, 2024 · 323957b · 323957b
1 parent 93186f1
commit 323957b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/lib/find-visualstudio.js b/lib/find-visualstudio.js
@@ -363,7 +363,11 @@ class VisualStudioFinder {
         return path.join(info.path, 'MSBuild', '15.0', 'Bin', 'MSBuild.exe')
       }
       if (versionYear === 2019) {
-        return msbuildPath
+        if (process.arch === 'arm64' && this.msBuildPathExists(msbuildPathArm64)) {
+          return msbuildPathArm64
+        } else {
+          return msbuildPath
+        }
       }
     }
     /**

diff --git a/test/test-find-visualstudio.js b/test/test-find-visualstudio.js
@@ -21,13 +21,7 @@ class TestVisualStudioFinder extends VisualStudioFinder {
   }
 }
 
-const shouldSkip = process.platform !== 'win32'
-
 describe('find-visualstudio', function () {
-  if (shouldSkip) {
-    return
-  }
-
   this.beforeAll(function () {
     // Condition to skip the test suite
     if (process.env.SystemRoot === undefined) {