Skip to content

Commit

Permalink
chore: remove unnecessary comment, fix spelling errors
Browse files Browse the repository at this point in the history
  • Loading branch information
owl-from-hogvarts committed May 20, 2021
1 parent d7cafb8 commit 0f87455
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 0 additions & 4 deletions lib/find-python.js
Original file line number Diff line number Diff line change
Expand Up @@ -579,10 +579,6 @@ class PythonFinder {
this.addLog(`${colorizeOutput(colorHighlight.RED, `${prop.toUpperCase()}:`)} ${err.data[prop].trim()}`)
}
}

// if (error.data.stderr) {
// this.addLog(`${colorizeOutput(colorHighlight.RED, 'STDERR:')} ${error.data.stderr.trim()}`)
// }
}
this.addLog('--------------------------------------------')
}
Expand Down
6 changes: 3 additions & 3 deletions test/test-find-python.js
Original file line number Diff line number Diff line change
Expand Up @@ -303,14 +303,14 @@ test('find-python', { buffered: true }, (t) => {
t.end()
})

await t.test(`test with path contain "${testString}"`, async (t) => {
await t.test(`test with path containing "${testString}"`, async (t) => {
// making fixture
paths.testDir = fs.mkdtempSync(path.resolve(paths.baseDir, 'node_modules', 'pythonFindTestFolder-'))

// using "junction" to avoid permission error
fs.symlinkSync(paths.pythonDir, path.resolve(paths.testDir, testString), 'junction')
console.log('πŸš€ ~ file: test-find-python.js ~ line 312 ~ awaitt.test ~ path.resolve(paths.testDir, testString)', path.resolve(paths.testDir, testString))
console.log('πŸš€ ~ file: test-find-python.js ~ line 312 ~ awaitt.test ~ paths.pythonDir', paths.pythonDir)
console.log('πŸš€ ~ file: test-find-python.js ~ line 312 ~ await.test ~ path.resolve(paths.testDir, testString)', path.resolve(paths.testDir, testString))
console.log('πŸš€ ~ file: test-find-python.js ~ line 312 ~ await.test ~ paths.pythonDir', paths.pythonDir)

const { pythonFinderInstance, result } = promisifyPythonFinder(path.resolve(paths.testDir, 'python'))

Expand Down

0 comments on commit 0f87455

Please sign in to comment.