src: restore ability to run under NAPI_EXPERIMENTAL #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might have been thinking of another change but I thought we had made it opt-in with another define? @legendecas is that right? |
I'm afraid that I didn't understand this assumption. Is this assumption unique to node-addon-api, not the node-api c layer? |
gabrielschulhof
force-pushed
the
restore-ability-to-run-with-NAPI_EXPERIMENTAL
branch
2 times, most recently
from
8f78a76
to
8b19089
Compare
gabrielschulhof
force-pushed
the
restore-ability-to-run-with-NAPI_EXPERIMENTAL
branch
from
8b19089
to
2c5853a
Compare
Since we made the default for Node.js core finalizers synchronous for
users running with `NAPI_EXPERIMENTAL` and introduced
`env->CheckGCAccess()` in Node.js core, we must now defer all
finalizers in node-addon-api, because our users likely make non-gc-safe
Node-API calls from existing finalizers. To that end,
* Use the NAPI_VERSION environment variable to detect whether
`NAPI_EXPERIMENTAL` should be on, and add it to the defines if
`NAPI_VERSION` is set to `NAPI_VERSION_EXPERIMENTAL`, i.e.
2147483647.
* When building with `NAPI_EXPERIMENTAL`,
* render all finalizers asynchronous, and
* expect `napi_cannot_run_js` instead of `napi_exception_pending`.
gabrielschulhof
force-pushed
the
restore-ability-to-run-with-NAPI_EXPERIMENTAL
branch
from
2c5853a
to
f89a09b
Compare
|
Core status of needed changes:
|
|
Hi @gabrielschulhof , Looks like this is becoming of more importance. I can take a look at continuing this work? Judging by the latest CI failure, looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we made the default for Node.js core finalizers synchronous for users running with
NAPI_EXPERIMENTALand introducedenv->CheckGCAccess()in Node.js core, we must now defer all finalizers in node-addon-api, because our users likely make non-gc-safe Node-API calls from existing finalizers. To that end,NAPI_EXPERIMENTALshould be on, and add it to the defines ifNAPI_VERSIONis set toNAPI_VERSION_EXPERIMENTAL, i.e. 2147483647.NAPI_EXPERIMENTAL,napi_cannot_run_jsinstead ofnapi_exception_pending.