Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for async contexts #1164

Merged
merged 1 commit into from Apr 29, 2022
Merged

Add test coverage for async contexts #1164

merged 1 commit into from Apr 29, 2022

Conversation

JckXia
Copy link
Member

@JckXia JckXia commented Apr 16, 2022

Add unit test for async context. This will close this github issue: #1038

@JckXia JckXia force-pushed the add-test-coverage-for-async-cxt branch from 6cbb513 to 87dcf57 Compare April 20, 2022 21:56
KevinEady
KevinEady approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It appears to test AsyncContext() constructor with no resource object as well as the context.Env() method, which were the two remaining methods in #1038

@JckXia
Copy link
Member Author

JckXia commented Apr 29, 2022

Thanks for the review @KevinEady. Yep It covers the remaining methods for AsyncContext

@JckXia JckXia merged commit f32db91 into nodejs:main Apr 29, 2022
@JckXia
Copy link
Member Author

JckXia commented Apr 29, 2022

Landed as f32db91

@JckXia JckXia mentioned this pull request Apr 29, 2022
Closed
@JckXia JckXia deleted the add-test-coverage-for-async-cxt branch April 29, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinEady KevinEady KevinEady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JckXia @KevinEady