Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix compilation problem on debian 8. #1138

Closed
wants to merge 4 commits into from
Closed

test: fix compilation problem on debian 8. #1138

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a2256e
test: fix compilation problem on debian 8.
NickNaso Feb 19, 2022
3d12ac1
fix compilation error on debian8.
NickNaso Feb 19, 2022
a60a470
Update test/objectwrap_function.cc
mhdawson Feb 21, 2022
c8f87d8
Update test/objectwrap_function.cc
mhdawson Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/objectwrap_function.cc
View file
Open in desktop
Expand Up @@ -36,7 +36,8 @@ class FunctionTest : public Napi::ObjectWrap<FunctionTest> {
};

std::unordered_map<napi_env, Napi::FunctionReference>
FunctionTest::constructors = {};
FunctionTest::constructors =
mhdawson marked this conversation as resolved.
Show resolved Hide resolved
std::unordered_map<napi_env, Napi::FunctionReference>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just dropping the = or the = {} would also do the trick here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I just tested out, removing the = {}

mhdawson marked this conversation as resolved.
Show resolved Hide resolved

Napi::Object InitObjectWrapFunction(Napi::Env env) {
Napi::Object exports = Napi::Object::New(env);
Expand Down