chore: use new constructor for ScriptOrigin when >= 17.x #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was the check originally for Node 18? I am AFK for about a week and cannot look into it until later.
…On November 1, 2023 9:26:18 PM GMT+01:00, Shelley Vohr ***@***.***> wrote:
Refs https://chromium-review.googlesource.com/c/v8/v8/+/3395880.
Chromium did an advance deprecation removal of the `ScriptOrigin` ctor without an Isolate.
This allows Electron to remove a [patch](https://github.com/electron/electron/blob/61374019c03ab1af8584550277318ba7c2adb0ca/patches/nan/use_new_constructor_for_scriptorigin_when_17_x.patch#L1-L29)
You can view, comment on, or merge this pull request online at:
#960
-- Commit Summary --
* chore: use new constructor for ScriptOrigin when >= 17.x
-- File Changes --
M test/cpp/news.cpp (4)
-- Patch Links --
https://github.com/nodejs/nan/pull/960.patch
https://github.com/nodejs/nan/pull/960.diff
|
|
@kkoopa that's when the new constructor was initially slated to be removed, but they moved up the date after all uses in Chromium got removed it seems. |
|
@kkoopa I'd still love a look at this when you can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://chromium-review.googlesource.com/c/v8/v8/+/3395880.
Chromium did an advance deprecation removal of the
ScriptOriginctor without an Isolate.This allows Electron to remove a patch