Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing methods to Nan::Maybe<T> #852

Merged
merged 2 commits into from May 16, 2019
Merged

Add missing methods to Nan::Maybe<T> #852

merged 2 commits into from May 16, 2019

Commits on May 16, 2019

  1. Add missing methods to Nan::Maybe<T> 

    Nan::Maybe<T> was an alias for v8::Maybe<T> with most Node.js versions
but that's problematic because v8::Maybe<T> has grown new methods over
time that are missing in older versions.

From now on we use our custom Maybe<T> implementation with all Node.js
versions. This commit also adds the following missing methods:

* Maybe<T>::Check() const
* Maybe<T>::To(T*) const
* Maybe<T>::ToChecked() const

Fixes: #851
    @bnoordhuis
    bnoordhuis committed May 16, 2019
    Copy the full SHA
    284f943 View commit details
    Browse the repository at this point in the history

  2. Fix cpplint warnings. 

    The code base is now `make lint`-clean again.
    @bnoordhuis
    bnoordhuis committed May 16, 2019
    Copy the full SHA
    d1131c7 View commit details
    Browse the repository at this point in the history