Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings-test.js fails on s390x #935

Open
bryceharrington opened this issue Apr 2, 2022 · 0 comments
Open

strings-test.js fails on s390x #935

bryceharrington opened this issue Apr 2, 2022 · 0 comments

Comments

@bryceharrington
Copy link

We're running into this in Ubuntu's 22.04 CI:
https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/s390x/n/node-nan/20220306_113841_a17b2@/log.gz

534 passing (12s)
1 failing

  1. test/js/strings-test.js FromV8String should be equal:

    Error: should be equal

    • expected - actual

    -栀攀氀氀漀
    +hello

    at Test. (test/js/strings-test.js:36:5)
    at Object. (test/js/strings-test.js:14:1)

I wonder if this might be an endian issue with the usage of the Buffer class? We can disable the test but a fix/workaround would be most appreciated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bryceharrington