Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nan tests fail on three platforms with Node.js 20.x #996

Open
Trott opened this issue Oct 1, 2023 · 2 comments
Open

nan tests fail on three platforms with Node.js 20.x #996

Trott opened this issue Oct 1, 2023 · 2 comments

Comments

@Trott
Copy link
Member

Trott commented Oct 1, 2023

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3297/testReport/ shows failures on win-vs2019, rhel8-s390x, and aix72-ppc64. Is someone likely to investigate these any time soon or would it be best to skip on those platforms for now? (Honest question, no judgment, just trying to figure out the best path forward.)

@nodejs/addon-api @nodejs/citgm

@richardlau
Copy link
Member

The rhel8-s390x and aix72-ppc64 failures are nodejs/nan#935 and almost certainly an endianness problem (no idea how easy it will be to fix).

@alfonsograziano
Copy link
Contributor

alfonsograziano commented Oct 8, 2023

@Trott unfortunately it is not bound to v20.x.
It also failed in this run with v18.18.

Shall we skip it for these platforms for now until a proper solution is found? (#1005)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants