Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions #403

Closed
wants to merge 2 commits into from
Closed

Upgrade GitHub Actions #403

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 14, 2022

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #403 (aa5ecf4) into main (ff75da7) will decrease coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   77.52%   77.14%   -0.38%     
==========================================
  Files          34       34              
  Lines        5027     5027              
==========================================
- Hits         3897     3878      -19     
- Misses       1130     1149      +19     
Impacted Files Coverage Δ
src/llscan.cc 60.56% <0.00%> (-1.86%) ⬇️
src/llv8.cc 71.67% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@No9
Copy link
Member

No9 commented Aug 14, 2022

Hey @cclauss thanks for the PR but this work is already covered under these two PRs
llvm - #389
16/18 upgrade #399
If you're trying for something else then please let us know or we can close this PR.

@cclauss
Copy link
Contributor Author

cclauss commented Aug 14, 2022

Let's merely upgrade the GitHub Actions.

@No9
Copy link
Member

No9 commented Aug 15, 2022

Excellent - The bump of actions, especially to the official setup-node, is very useful.
As this could impact #389 from both a merge and feature perspective I'm going to land that first then merge this.
Current plan is to do the merge of 389 by the end of this week - 2022-08-21.

Edit: I thought this fixed https://github.com/cclauss/llnode/blob/6ac110d4f6fea7b898b01e4b67669d502b15c07d/.github/workflows/push.yml#L35
But it looks like this PR needs to be updated actions/setup-node#360
I still think it would be good to land this but the dep on my setup-node needs to be fixed.

@No9
Copy link
Member

No9 commented Aug 17, 2022

Hey @cclauss
#389 has merged - If you could rebase this I would be happy to help land

@cclauss
Copy link
Contributor Author

cclauss commented Aug 18, 2022

Rebased. Also fixed runs-on: to take a string, not an array because the runner is not self-hosted.

@No9
Copy link
Member

No9 commented Aug 18, 2022

Hey @cclauss
There seems to be a tests that are on the edge of the timeouts for node14 with lldb12

Would you mind bumping

t.timeoutAfter(15000);

to 30000
and
t.timeoutAfter(30000);

to 60000
And set the defaults to 40000
this.timeout = timeout || 20000;

const timeout = parseInt(process.env.TEST_TIMEOUT) || 20000;

Thanks

kvakil added a commit to kvakil/llnode that referenced this pull request Aug 29, 2022
Refs: nodejs#403
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Anton Whalley <anton@venshare.com>
@cclauss
Copy link
Contributor Author

cclauss commented Sep 13, 2022

@No9 Your re-review, please.

@No9
Copy link
Member

No9 commented Sep 13, 2022

@cclauss
Copy link
Contributor Author

cclauss commented Sep 14, 2022

Closing in favor of #404

@cclauss cclauss closed this Sep 14, 2022
@cclauss cclauss deleted the patch-1 branch September 14, 2022 05:01
No9 added a commit that referenced this pull request Sep 14, 2022
Refs: #403
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Anton Whalley <anton@venshare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants