Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup to latest, ignore ArrayBufferView and Arrow #398

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

No9
Copy link
Member

@No9 No9 commented Nov 16, 2021

This PR uses the latest version of setup-node merged with the mirror branch from mmarchini's version.
https://github.com/No9/setup-node/tree/mirror
That branch has also been PR'd into the actions/setup-node upstream
actions/setup-node#360
If that isnt accepted I'm happy to open up a repo transfer request.

This PR also disables the ArrayBufferView and Arrow tests as they are currently failing.
The ArrayBufferView was identified here #375 and appears to be an upstream issue with the mappings that are generated during the V8 build. It would be great to confirm that with @nodejs/post-mortem folks though.

The Arrow test is looking for a different function comparison in the test
In 14.x it returns

[25]=0x3257a72b7c89:<function: 3378328 at /home/anton/build/llnode/test/fixtures/inspect-scenario.js:75:19>

Instead of 12.x

[25]=0x000036eccf7c0b79:<function: c.hashmap.(anonymous function) at /foo/bar.js:63:19>}

This is failing this regex

/\[25\]=(0x[0-9a-f]+):<(function: c.hashmap).*>/

If that is expected I can update the regex to be

/\[25\]=(0x[0-9a-f]+):<(function:.*>/

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #398 (d3ae04e) into main (934ff7c) will decrease coverage by 2.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   79.43%   76.58%   -2.85%     
==========================================
  Files          34       34              
  Lines        5023     5023              
==========================================
- Hits         3990     3847     -143     
- Misses       1033     1176     +143     
Impacted Files Coverage Δ
src/llv8-inl.h 82.16% <0.00%> (-8.54%) ⬇️
src/llv8-constants.cc 80.09% <0.00%> (-6.22%) ⬇️
src/printer.cc 74.30% <0.00%> (-5.70%) ⬇️
src/llv8.h 72.41% <0.00%> (-5.18%) ⬇️
src/llv8-constants.h 94.28% <0.00%> (-4.29%) ⬇️
src/llv8.cc 69.41% <0.00%> (-2.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934ff7c...d3ae04e. Read the comment docs.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@mmarchini are you going to get a chance to look at this as well?

@No9 No9 merged commit 39b38a9 into nodejs:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants