Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decode bytes not str (easy_xml.py) #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: decode bytes not str (easy_xml.py) #160

wants to merge 1 commit into from

Conversation

owl-from-hogvarts
Copy link
Contributor

See nodejs/node-gyp/issues/2505

proper fix for #118
Special thanks to @cclauss

@cclauss
Copy link
Contributor

cclauss commented Aug 30, 2022

Please rebase so we can ensure that the tests pass.

@owl-from-hogvarts
fix: decode bytes not str
67393c1 
proper fix for nodejs#118
Special thanks to @cclauss
@owl-from-hogvarts
Copy link
Contributor Author

Please rebase so we can ensure that the tests pass.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owl-from-hogvarts @cclauss